Update jQuery to 3.6.3 #19989
Merged
Update jQuery to 3.6.3 #19989
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 tasks
sgiehl
force-pushed
the
jquery3
branch
2 times, most recently
from
ffa99e0
to
6f9c0c5
Compare
|
If you don't want this PR to be closed automatically in 28 days then you need to assign the label 'Do not close'. |
github-actions
bot
added
the
Stale
sgiehl
force-pushed
the
jquery3
branch
6 times, most recently
from
c4c2099
to
b0f8588
Compare
sgiehl
force-pushed
the
jquery3
branch
4 times, most recently
from
8c7b1c1
to
9bfcfb9
Compare
sgiehl
force-pushed
the
jquery3
branch
4 times, most recently
from
044ec1a
to
358ce04
Compare
|
For some reason the UI tests have started to fail more often on this branch. I'm not yet sure how this is related to jQuery 3.6. Tried adding some more debugging to the tests, but might need to investigate the failures bit further... |
sgiehl
force-pushed
the
jquery3
branch
2 times, most recently
from
4c06721
to
7deab51
Compare
bx80
approved these changes
Mar 24, 2023
There was a problem hiding this comment.
The UI tests look good, (except for some randoms which are present on other branches). I did some manual testing moving around the UI and checking the browser console, but didn't encounter any issues 👍
- Functional review done
- Potential edge cases thought about (behavior of the code with strange input, with strange internal state or possible interactions with other Matomo subsystems)
- Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
- Security review done
- Wording review done
- Code review done
- Test updated Tests were added if useful/possible
- Note added Reviewed for breaking changes
- Developer changelog updated if needed
- Documentation added if needed
- Existing documentation updated if needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
replaces #19945
Review