add callBackQueue to process callBack, when clientHintsRequestQueue is used #19983
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 10, 2022 13:45
add callBackQueue
add callBackQueue to consent request
|
build js |
peterhashair
added
the
not-in-changelog
added 3 commits
November 10, 2022 14:19
remove send bulk request queue
test callback on BrowserFeatureDetectionEnabled
|
build js |
bx80
approved these changes
Nov 10, 2022
There was a problem hiding this comment.
Tested the callback on 4.x.dev - firefox does the callback, chromium doesn't. Same tests with this PR, both browsers do the callback 👍
- Functional review done
- Potential edge cases thought about (behavior of the code with strange input, with strange internal state or possible interactions with other Matomo subsystems)
- Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
- Security review done
- Wording review done
- Code review done
- Tests were added if useful/possible
- Reviewed for breaking changes
- Developer changelog updated if needed
- Documentation added if needed
- Existing documentation updated if needed
bx80
pushed a commit
that referenced
this pull request
Nov 25, 2022
…s used (#19983) * add callBackQueue add callBackQueue * add callBackQueue to consent request add callBackQueue to consent request * rebuilt piwik.js * remove send bulk request queue remove send bulk request queue * test callback on BrowserFeatureDetectionEnabled test callback on BrowserFeatureDetectionEnabled * rebuilt piwik.js Co-authored-by: peterhashair <peterhashair@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Fixes: #19862
introduce
callBackQueueto process callback, whenclientHintsRequestQueue/consentRequestsQueueis usedSince we add the queue is working on callback. remove this line of tests
Review