Improve / fix handling of best converting page on goal overview #19972
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgiehl
added
not-in-changelog
update screenshots
peterhashair
approved these changes
Nov 9, 2022
There was a problem hiding this comment.
Working as expected, sorry pushed some UI screenshots that need an update, I believe one is from my PR that already merged.
- Functional review done
- Potential edge cases thought about (behavior of the code with strange input, with strange internal state or possible interactions with other Matomo subsystems)
- Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
- Security review done
- Wording review done
- Code review done
- Tests were added if useful/possible
- Reviewed for breaking changes
bx80
suggested changes
Nov 9, 2022
There was a problem hiding this comment.
I've done some functional testing, the tooltip works and broken URL is removed. 👍
The original issue mentions that a directory shouldn't be shown as the top entry URL. When testing locally my top entry page is shown as 'blog' which is a directory. The top dimensions request might need to be filtered to exclude directories?
|
@bx80 That should be fixed now. I've changed the request for entry pages and added |
peterhashair
reviewed
Nov 9, 2022
update screenshot
peterhashair
approved these changes
Nov 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
fixes #19512
fixes #20003
Review