Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid double formatting of conversion rate in comparison mode #19970

Merged
merged 1 commit into from Nov 9, 2022
Merged

Avoid double formatting of conversion rate in comparison mode #19970

merged 1 commit into from Nov 9, 2022

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Nov 8, 2022

Description:

When viewing a goals report in comparison mode I got the following error in log:

WARNING CoreHome[2022-11-08 13:38:15 UTC] [871ee] /srv/matomo/core/Metrics/Formatter.php(161): Notice - A non well formed numeric value encountered - Matomo 4.12.3 - Please report this message in the Matomo forums: https://forum.matomo.org (please do a search first as it might have been reported already) #0/core/Metrics/Formatter.php(161),#1/plugins/CoreHome/Columns/Metrics/ConversionRate.php(42),#2/plugins/CoreVisualizations/Visualizations/Sparklines.php(259),#3/plugins/CoreVisualizations/Visualizations/Sparklines.php(108),#4/core/Plugin/Report.php(320),#5/plugins/CoreHome/Controller.php(60),[internal function]: Piwik\Plugins\CoreHome\Controller->renderReportWidget(),#7/core/FrontController.php(631),#8/core/FrontController.php(169),#9/core/dispatch.php(32)

Turned out, that in comparison mode, the values seem to be formatted twice. That actually caused the numbers to be incorrect. Instead of 1,8% it was displayed as 100%

Might be related to #19954

Review

@sgiehl sgiehl added Bug For errors / faults / flaws / inconsistencies etc. Needs Review PRs that need a code review Regression Indicates a feature used to work in a certain way but it no longer does even though it should. labels Nov 8, 2022
@sgiehl sgiehl added this to the 4.12.4 milestone Nov 8, 2022
@sgiehl sgiehl marked this pull request as ready for review November 8, 2022 14:46
@tsteur tsteur mentioned this pull request Nov 8, 2022
Open
bx80
bx80 approved these changes Nov 9, 2022
View reviewed changes
Copy link
Contributor

@bx80 bx80 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bx80 bx80 merged commit 57b3321 into 4.x-dev Nov 9, 2022
@bx80 bx80 deleted the fixconvrate branch November 9, 2022 01:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bx80 bx80 bx80 approved these changes

Assignees
No one assigned
Labels
Bug For errors / faults / flaws / inconsistencies etc. Needs Review PRs that need a code review Regression Indicates a feature used to work in a certain way but it no longer does even though it should.
Projects
None yet
Milestone
4.12.4
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sgiehl @bx80