New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Trunk: tests/core/Piwik/serveStaticFile.test.php fails on fresh trunk export on windows #1997
Comments
Attachment: output of the test on windows php 5.2.6 |
I've set up two php versions via CGI : 5.1.3 and 5.3.5. The error is only reproducible on 5.1.3. The error occurs while using CURL and gzdeflate(). In both PHP version I had a look at response headers set by CURL using :
In PHP 5.1.3 I get :
In PHP 5.3.5 I get
As you can see, in 5.1.3 [and download_content_length do not match. It means the response has not been correctly decoded and "" is returned by CURL when requesting for the payload. Using gzcompress instead of gzdeflate resolves the issue. However, gzdeflate as been used for IE compatibility. Not sure what to do next.. |
Interesting. On 5.1.3 and 5.3.5, I get the same result returned by both. This is my config.nice for 5.1.3:
|
I tried setting for 5.1.3
to match your config. no change in behavior. |
Well, all_tests.php on trunk r3724 works for me on Windows Vista, IIS with php 5.2.14 (installed via IIS WebPI). I don't think we should be surprised if some of the unit tests break with older php5 versions on Windows. For example, the changelog for 5.3.0 says:
|
if you guys cant find a fix and can confirm it works on newer versions of php, shall we 'wontfix' ? |
Julien, on 5.3.5 on apache tests pass for you? If there is indeed a bug on windows in some php versions, what are the consequences on the asset manager logic? what will fail to work? My box with the test failing seems to deal well with merged assets. Please confirm and/or mark as wontfix |
As far as I understood, it's only the unit test that will fail in very specific box configurations. The serveStaticFile method logic should not be affected by this. Marking as wontfix. |
On a fresh trunk import on Windows (and also on my old trunk working copy) the test serveStaticFile.test.php fails with the following errors:
Maybe this is a bug, or maybe just a test bug.
The text was updated successfully, but these errors were encountered: