Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visits over time chart and other evolution graphs show wrong period when comparing segments #19967

Open
tsteur opened this issue Nov 8, 2022 · 4 comments
Labels
Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc.

Comments

@tsteur
Copy link
Member

tsteur commented Nov 8, 2022

See for example this link: https://demo.matomo.cloud/index.php?module=CoreHome&action=index&idSite=1&period=day&date=yesterday#?period=week&date=2022-11-04&category=Dashboard_Dashboard&subcategory=1&compareSegments%5B%5D=visitConvertedGoalId%3D%3D7

It is supposed to be showing weeks but it's comparing individual days in the graph
image

When switching to period to month, then it is still comparing days but the metric selector labels are correct
image

Same happens for other evolution graphs like in the goals overview https://demo.matomo.cloud/index.php?module=CoreHome&action=index&idSite=1&period=day&date=yesterday#?idSite=1&period=week&date=2022-11-04&compareSegments%5B%5D=visitConvertedGoalId%3D%3D7&category=Goals_Goals&subcategory=General_Overview

It's mostly showing not useful data at all since it's for example the beginning of the month and for most days there would be no data yet.

Expected:
It should behave as usual when not comparing. Meaning when a week is selected, it should show the data for the last X weeks. When a month is selected, it should show the data for the last X months.

Don't know if this is maybe a regression?

@tsteur tsteur added the Potential Bug Something that might be a bug, but needs validation and confirmation it can be reproduced. label Nov 8, 2022
@tsteur tsteur changed the title Visits over time chart shows wrong period when comparing segments Visits over time chart and other evolution graphs show wrong period when comparing segments Nov 8, 2022
@tsteur
Copy link
Member Author

tsteur commented Nov 8, 2022

Basically, the segment comparing feature is no longer usable for me.

@sgiehl
Copy link
Member

sgiehl commented Nov 8, 2022

might be related to #19395

@peterhashair peterhashair added Waiting for user feedback Indicates the Matomo team is waiting for feedback from the author or other users. Regression Indicates a feature used to work in a certain way but it no longer does even though it should. Needs priority decision This issue may need to be added to the current milestone by Product Manager and removed Potential Bug Something that might be a bug, but needs validation and confirmation it can be reproduced. Waiting for user feedback Indicates the Matomo team is waiting for feedback from the author or other users. labels Nov 9, 2022
@sgiehl
Copy link
Member

sgiehl commented Sep 29, 2023

I've just checked that one again. Looks like we meanwhile fully hide the period selection in evolution charts when comparing data. See #20100. Also it's on purpose that the chart only shows the period in detail.
There is also #17582 which is kind of a duplicate to this one.
We might want to reactivate the period selection there at some point, but that requires a clear definition how the graph should behave then and also a proper implementation of those requirements. This regression issue can imho be closed.

@sgiehl sgiehl removed the Needs priority decision This issue may need to be added to the current milestone by Product Manager label Sep 29, 2023
@Stan-vw
Copy link
Contributor

Stan-vw commented Oct 9, 2023

@tsteur I understand from the comment above that you made #20100 which now "solves" this problem (since it's now intended). Can you let me know if this ticket should now be closed, or describe what the exact problem is that still exists?
Thanks 🙏

@Stan-vw Stan-vw added Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. and removed Regression Indicates a feature used to work in a certain way but it no longer does even though it should. labels Oct 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc.
Projects
None yet
Development

No branches or pull requests

5 participants