Set default limit for concurrent archivers #19959
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update default to 3 and -1 to unlimited
added 5 commits
November 8, 2022 10:57
update default
update tests
update max default to 3
update tests
peterhashair
added
Needs Review
update concurrent-archivers in change log
bx80
approved these changes
Nov 10, 2022
There was a problem hiding this comment.
This tested well for me, running the core:archive command with no parameters defaulted to a maximum of three processes, this could be overridden using the --concurrent-archivers parameter either with a specific number of archivers or with -1 👍
- Functional review done
- Potential edge cases thought about (behavior of the code with strange input, with strange internal state or possible interactions with other Matomo subsystems)
- Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
- Security review done
- Wording review done
- Code review done
- Existing tests updated Tests were added if useful/possible
- Reviewed for breaking changes
- Note added Developer changelog updated if needed
- Documentation added if needed
- Existing documentation updated if needed
bx80
pushed a commit
that referenced
this pull request
Nov 25, 2022
* update default to 3 and -1 to unlimited update default to 3 and -1 to unlimited * update default update default * update tests update tests * update max default to 3 update max default to 3 * update tests update tests * update concurrent-archivers in change log update concurrent-archivers in change log
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Fixes: #18375
Set default limit for concurrent archivers
Review