Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Segment auto suggest capitalization #19958

Merged
merged 3 commits into from Nov 9, 2022
Merged

Segment auto suggest capitalization #19958

merged 3 commits into from Nov 9, 2022

Conversation

peterhashair
Copy link
Contributor

@peterhashair peterhashair commented Nov 7, 2022

Description:

Segment auto suggest capitalization

CP of #19773, update UI screenshots

Review

@peterhashair peterhashair linked an issue Nov 7, 2022 that may be closed by this pull request
@peterhashair peterhashair added this to the 5.0.0 milestone Nov 7, 2022
@peterhashair peterhashair added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Nov 7, 2022
update screenshots
@peterhashair peterhashair marked this pull request as ready for review November 7, 2022 21:53
@peterhashair peterhashair added the Needs Review PRs that need a code review label Nov 7, 2022
@sgiehl
Copy link
Member

sgiehl commented Nov 8, 2022

@mattab could you quickly confirm that this PR (which was originally provided by the community) is something we want to go with. Might be a small change, but I want to avoid, that we might need to revert it later...

@mattab
Copy link
Member

mattab commented Nov 8, 2022

Looks good to me 👍

@sgiehl sgiehl merged commit b4db64d into 5.x-dev Nov 9, 2022
@sgiehl sgiehl deleted the m19777 branch November 9, 2022 09:48
bx80 pushed a commit that referenced this pull request Nov 25, 2022
* Remove uppercase from segment dropdown

* update screenshots

update screenshots

Co-authored-by: Tom <thomas.czernik@webreload.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Segment auto suggest capitalization
4 participants