Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add global types for datatable row action classes/code #19953

Merged
merged 2 commits into from Nov 7, 2022
Merged

add global types for datatable row action classes/code #19953

merged 2 commits into from Nov 7, 2022

Conversation

diosmosis
Copy link
Member

@diosmosis diosmosis commented Nov 5, 2022 •
edited

Description:

So it's possible to add row actions in typescript.

Also added a property to PiwikGlobal for siteMainUrl.

Review

@diosmosis diosmosis added the Needs Review PRs that need a code review label Nov 5, 2022
@diosmosis diosmosis added this to the 5.0.0 milestone Nov 5, 2022
@sgiehl sgiehl merged commit 448ec4a into 5.x-dev Nov 7, 2022
@sgiehl sgiehl deleted the row-action-types branch November 7, 2022 14:22
@elabuwa elabuwa added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Nov 22, 2022
bx80 pushed a commit that referenced this pull request Nov 25, 2022
@diosmosis @bx80
add global types for datatable row action classes/code (#19953)
e80812a 
* add global types for datatable row action classes/code

* Add siteMainUrl property to PiwikGlobal.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
5.0.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@diosmosis @sgiehl @elabuwa