Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor handling of campaign parameters #19951

Open
sgiehl opened this issue Nov 4, 2022 · 2 comments
Open

Refactor handling of campaign parameters #19951

sgiehl opened this issue Nov 4, 2022 · 2 comments
Labels
c: Tracking For issues related to getting tracking data into Matomo. Technical debt Issues the will help to reduce technical debt

Comments

@sgiehl
Copy link
Member

sgiehl commented Nov 4, 2022

Currently all campaign parameters tracked in core (as well as in MarketingCampaignsReporting plugin) are stored on lower case in the database.

This is actually a manipulation of the provided data we should avoid as there might be reasons why this might cause trouble.
For example a click id might contain upper and lower case letters, changing them might make the click id not usable anymore, as it differs from the one stored on the advertising network.

We should remove the code that lowers the data in core as well as in the plugin.

To achieve some sort of backwards compatibility we could introduce config values for each report, to configure if the report should be generated case sensitive or insensitive.
For new installs this could be directly set to case sensitive. Old installs would set it to case insensitive using an update script to keep bc.

Alternatively we could also add a visualization option to enable case in-/sensitivity in the UI maybe.

The solution we implement in core also needs to be implemented in MarketingCampaignsReporting plugin.

follow-up to matomo-org/plugin-MarketingCampaignsReporting#65

see also matomo-org/plugin-MarketingCampaignsReporting#27

@sgiehl sgiehl added the c: Tracking For issues related to getting tracking data into Matomo. label Nov 4, 2022
@sgiehl sgiehl added this to the For Prioritization milestone Nov 4, 2022
@MatomoForumNotifications

This issue has been mentioned on Matomo forums. There might be relevant details there:

https://forum.matomo.org/t/mtm-cid-gclid-converted-to-lower-case/49956/2

@9joshua
Copy link
Contributor

9joshua commented May 25, 2023

I have another request for this from a customer who sees their Click ID occasionally converted to lowercase. This makes conversion exports unusable as Click IDs are case-sensitive.

@sgiehl sgiehl added the Technical debt Issues the will help to reduce technical debt label Aug 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: Tracking For issues related to getting tracking data into Matomo. Technical debt Issues the will help to reduce technical debt
Projects
None yet
Development

No branches or pull requests

3 participants