Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Invalidations of reports command should allow to invalidate "All visits" only #19947

Open
tsteur opened this issue Nov 3, 2022 · 3 comments
Open

Invalidations of reports command should allow to invalidate "All visits" only #19947

tsteur opened this issue Nov 3, 2022 · 3 comments
Labels
c: Performance For when we could improve the performance / speed of Matomo. Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. Stability For issues that make Matomo more stable and reliable to run for sys admins.
Milestone
5.2.0

Comments

@tsteur
Copy link
Member

tsteur commented Nov 3, 2022

Currently, when running ./console core:invalidate-report-data --sites=1 --dates=2022-10-01,2022-10-10, then all reports for the "All visits" segment and all other segments for that site are invalidated. This can cause a huge amount of invalidations which can put a lot of load onto a database and as a result it will take very long to reprocess this data.

It would be be great if we could specify something like --segment="" and then only the "All Visits" segment should be invalidated but not any other segments (unless specific other segments are also specified).

You can reproduce this by running ./console core:invalidate-report-data --sites=1 --dates=2022-10-01,2022-10-10 and then you will see invalidations in the archive_invalidations table for the done archive name and also for all the segments. Expected would be to only see archive invalidations for the done archive name.
@tsteur tsteur added Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. c: Performance For when we could improve the performance / speed of Matomo. Stability For issues that make Matomo more stable and reliable to run for sys admins. labels Nov 3, 2022
@mattab mattab added this to the Impact Backlog milestone Nov 4, 2022
@mattab mattab modified the milestones: Impact Backlog, 4.12.5 Nov 13, 2022
@justinvelluppillai justinvelluppillai modified the milestones: 4.12.5, 4.13.2 Nov 28, 2022
@mattab mattab modified the milestones: 4.13.2, 5.1.0 Dec 5, 2022
@mattab mattab added the 5.1.0 label Jan 4, 2023
@mattab mattab removed the 5.1.0 label Aug 4, 2023
@snake14 snake14 mentioned this issue Sep 13, 2023
Open
@Stan-vw
Copy link
Contributor

Stan-vw commented Sep 28, 2023

@mattab why is this tagged as 5.1.0, this doesn't sound like extremely high value to a large group of users. Am I missing something?
Also I see it's been shifted to further milestones quite a few times, can I just shift it to 5.5.0?

@tsteur
Copy link
Member Author

tsteur commented Sep 28, 2023

@Stan-vw This one is important for us on the Cloud to avoid getting paged when this command is used etc.

@Stan-vw
Copy link
Contributor

Stan-vw commented Sep 29, 2023

Thanks for explaining Thomas, much appreciated 🙏

@sgiehl sgiehl modified the milestones: 5.1.0, 5.2.0 Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: Performance For when we could improve the performance / speed of Matomo. Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. Stability For issues that make Matomo more stable and reliable to run for sys admins.
Projects
None yet
Milestone
5.2.0
Development

No branches or pull requests
5 participants
@tsteur @mattab @justinvelluppillai @sgiehl @Stan-vw