Prepare github actions for Matomo 5 #19943
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgiehl
added
not-in-changelog
peterhashair
approved these changes
Nov 4, 2022
There was a problem hiding this comment.
Overall looks good, not urgent but do we consider using actions/checkout@v3 refer here https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/
Same as set-output refer here https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
Updating the action to use that stuff will require some more testing I guess. I would say that's out of scope for this PR, as it should only prepare some stuff for Matomo 5. We should maybe create an issue to update that stuff somewhen else. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Before releasing Matomo 5 we will soon switch the base branch from
4.x-devto5.x-dev. Some of our actions are automatically running on the base branch. For this purpose we need to update the used branch for some actions.Should be safe to already merge this, as the changes here should first be used when the base branch was changed.
But it should meanwhile already be possible to trigger the actions manually for
5.x-devafter this was merged.Review