New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add isFullRequest parameter to JS tracker queueRequest() … #19942
Conversation
…ant to call getRequest() ourselves before queueRequest()
This issue is in "needs review" but there has been no activity for 7 days. ping @matomo-org/core-reviewers |
@diosmosis would you solve the conflicts? |
@sgiehl updated |
added a test as well |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The javascript tests are failing and might need to be updated. Otherwise this imho looks good.
Might be possible though that our documentation needs an update.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
JS tests passed, not too sure that Redis tests are related, seems random.
- Functional review done
- Potential edge cases thought about (behavior of the code with strange input, with strange internal state or possible interactions with other Matomo subsystems)
- Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
- Security review done
- Wording review done
- Code review done
- Tests were added if useful/possible
- Reviewed for breaking changes
- Developer changelog updated if needed
* add isFullRequest parameter to JS tracker queueRequest() in case we want to call getRequest() ourselves before queueRequest() * add JS tracker tests * update expected count of requests
Description:
This PR adds the ability to use
queueRequest()
with a full tracker request URL (ie, the result ofgetRequest()
). The primary use case is when there is asynchronous code that is used to determine the contents of the request, and we want to make sure the correct parameters are used when the async code finishes. For example:Prevents the following type of error:
Review