@peterhashair opened this Pull Request on October 28th 2022 Contributor

Description:

Fixes : #19909
Used like <div piwik-show-help-link message="test"></div>

Review

@peterhashair commented on October 28th 2022 Contributor

@snake14 can you try this, if that works for the DEV-3145

@sgiehl commented on October 28th 2022 Member

@peterhashair Shouldn't that one also change _menu.twig, so the component is automatically used there if some help text is defined for an entry?

@snake14 commented on November 1st 2022 Contributor

@peterhashair Thank you for your effort. This is looking really good. I left one more comment about something that isn't working quite as expected.

@peterhashair commented on November 1st 2022 Contributor

as described in the JIRA ticket. This issue may be out of scope.
when we click the help icon from the current nav item to another nav Item, it doesn’t navigate to the target nav as the main menu does. (eg: click visitors->overview(help icon) then click visitors->visits log (help icon) It uses ajax load the page items and shows the help text at the top. Because the plugin page items do not load through ajax only through traditional URLs. To implement this, we maybe need to add a widget container for all plugins.
Let me know if we want to implement this.

This Pull Request was closed on November 2nd 2022
Powered by GitHub Issue Mirror