Add help link Vue component #19922
Add help link Vue component #19922
Conversation
add help link vue
|
@snake14 can you try this, if that works for the DEV-3145 |
|
@peterhashair Shouldn't that one also change |
update menu when _help define, show help icon
add help key
| placeat: '#notificationContainer', | ||
| prepend: true, | ||
| }); | ||
| }, |
There was a problem hiding this comment.
This shows the help notification well and clicking on a different help icon replaces the help text with that help text. However, there's one thing that this isn't doing that plugins/CoreHome/vue/src/ReportingMenu/ReportingMenu.vue does. When I click the same help icon twice, this code doesn't hide the purple notification. For example, from the Matomo dashboard, I select the Goals menu item and then click the help icon next to the Overview submenu to view the purple notification containing the help text. If I click that same help icon a second time, the purple notification is hidden.
There was a problem hiding this comment.
Thank you @peterhashair . It now hides when I click the icon a second time.
Every once in a while there's some odd behaviour when I click on the help icon next to one submenu and then the icon next to another submenu. In some cases it hides the notification instead of replacing it. Sometimes I have to click the help icon multiple times. Although, it's enough of a fringe case that it's probably fine to let through.
|
@peterhashair Thank you for your effort. This is looking really good. I left one more comment about something that isn't working quite as expected. |
add hide help message
update type string from null to empty
fix build build
fix vue build error
fix vue build
fix vue build
|
as described in the JIRA ticket. This issue may be out of scope. |
Description:
Fixes : #19909
Used like
<div piwik-show-help-link message="test"></div>Review