You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
mattab opened this issue
Jan 10, 2011
· 7 comments
Labels
BugFor errors / faults / flaws / inconsistencies etc.CriticalIndicates the severity of an issue is very critical and the issue has a very high priority.
From Joachim: "the fault is the uncommented / in the regex. With http://dev.piwik.org/trac/changeset/3344/trunk/core/Tracker/GoalManager.php,
the / are commented by piwik, but it is not checked, if they are already
commented out and also the example in piwik itself is not updated to the new
behaviour."
r3344 is a security best practice because the regex is user input. (If this was a preg_replace, it would have been a potentially serious vulnerability.)
Instead of an unescaped regex failing silently, we should have fixed the docs/examples. Vote to revert 3901.
BugFor errors / faults / flaws / inconsistencies etc.CriticalIndicates the severity of an issue is very critical and the issue has a very high priority.
A few users have been complaining that Goals are not matched since upgrade to 1.1.
We should add unit tests to test that goal matching works as expected in all supported use cases, if not fix the issue
The text was updated successfully, but these errors were encountered: