Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tag Manager updates won't run if updating from 4.12.1 to 4.12.2 #19905

Closed
Starker3 opened this issue Oct 24, 2022 · 0 comments · Fixed by #19906
Closed

Tag Manager updates won't run if updating from 4.12.1 to 4.12.2 #19905

Starker3 opened this issue Oct 24, 2022 · 0 comments · Fixed by #19906
Labels
not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Potential Bug Something that might be a bug, but needs validation and confirmation it can be reproduced.

Comments

@Starker3
Copy link
Contributor

This is effectively the same issue that was reported here:
matomo-org/tag-manager#557
#19886

It looks like we have the same issue with the 4.12.2 release that we had with the 4.12.1 release with Tag Manager.
Because the update file for the 4.12.2 release was not renamed to a 4.12.2 update file anyone who was already on 4.12.1 and updated to 4.12.2 would still have the same issue.
image
image

To get the updates to run they would need to set their version for Tag Manager to 4.12.0 and then run core:update again.
image

To properly fix it for everyone we would need to rename the update file to something like 4.12.3-b1.php and then release 4.12.3
@Starker3 Starker3 added the Potential Bug Something that might be a bug, but needs validation and confirmation it can be reproduced. label Oct 24, 2022
This was referenced Oct 24, 2022
Merged
Merged
@sgiehl sgiehl added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Potential Bug Something that might be a bug, but needs validation and confirmation it can be reproduced.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix to apply Tag Manager database update when upgrading from 4.12 matomo-org/matomo
2 participants
@sgiehl @Starker3