Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add INI setting to disable Password Confirmation #19904

Closed
Starker3 opened this issue Oct 24, 2022 · 10 comments
Closed

Add INI setting to disable Password Confirmation #19904

Starker3 opened this issue Oct 24, 2022 · 10 comments
Labels
Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. wontfix If you can reproduce this issue, please reopen the issue or create a new one describing it.

Comments

@Starker3
Copy link
Contributor

Starker3 commented Oct 24, 2022

Proposed solution

Proposed solution

  • introduce a new INI setting to let people disable the password confirmation.
  • create a new FAQ "How do I disable the password confirmation prompt?" that explains how it's not recommended because it lowers security, but when it's required for some reason, it's possible.
  • both core & WP users could leverage this setting if needed

For now i'd say we don't need to link to the FAQ within the app itself, as I guess it's very rarely needed so not worth maybe.

Note: workaround available

Bug description

Similar to matomo-org/plugin-LoginLdap#310

In some cases a Matomo admin might want to disable the password prompt that they get when performing any admin actions in a Matomo instance (Eg. creating a new user, changing settings, etc.)

For Matomo instances that have a high number of users and/or measurables this can mean that a Matomo admin enters their password for confirmation many times in a potentially short period of time.

With the new Password prompt implementation it is possible to disable the requirement for a password and instead just have a "Yes/No" prompt: #19525

However, from a security standpoint it would likely be best to have this still enabled by default and perhaps add a config option that could disable the password prompt.

@Starker3 Starker3 added the Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. label Oct 24, 2022
@peterhashair
Copy link
Contributor

peterhashair commented Oct 25, 2022

I will put this in the backlog for prioritization. But this may be will cause a security concern.

@peterhashair peterhashair added this to the For Prioritization milestone Oct 25, 2022
@xpufx
Copy link

xpufx commented Oct 28, 2022

I installed matomo 10 minutes ago and I am about ready to give up due to this weird behavior. Please make it optional as soon as possible. It's super annoying.

@justinvelluppillai
Copy link
Contributor

justinvelluppillai commented Oct 31, 2022

@mattab this is a fairly regular request after we made changes for security purposes. Perhaps we could provide workarounds for certain use cases.

See also #19772

@mattab
Copy link
Member

mattab commented Oct 31, 2022

How do other Saas tools like Github handle this? Do they remember for like 5minutes that the password was given, or something like this? There must be a common way to solve this problem and it would be great to learn what it is so we don't have to reinvent the wheel (and ideally we don't introduce a new setting...)

@lance-matomo
Copy link

There are a couple of Wordpress plugin users that can't use these password protected features at all, they keep getting incorrect password notifications. They tried updating their passwords, using simpler passwords, using more complex passwords and updating their passwords directly in the db. Nothing worked for them. I was unable to reproduce this locally.

@mattab mattab changed the title Add option to disable Password Confirmation Add INI setting to disable Password Confirmation Nov 8, 2022
@mattab
Copy link
Member

mattab commented Nov 8, 2022

Proposed solution

  • introduce a new INI setting to let people disable the password confirmation.
  • create a new FAQ "How do I disable the password confirmation prompt?" that explains how it's not recommended because it lowers security, but when it's required for some reason, it's possible.
  • both core & WP users could leverage this setting if needed

For now i'd say we don't need to link to the FAQ within the app itself, as I guess it's very rarely needed so not worth maybe.

@sgiehl
Copy link
Member

sgiehl commented Nov 9, 2022

It is kind of already possible to disable the password check by adding this to config/config.php

<?php

return [
    'observers.global' => \DI\add([
        ['Login.userRequiresPasswordConfirmation', \DI\value(function (&$requiresPasswordConfirmation, $login) {
            $requiresPasswordConfirmation = false;
        })],
    ]),
];

That way the password confirmation boxes are still shown, but you can simply click ok, without entring a password.
Might be a suitable solution for the users currently having a problem.

@mattab
Copy link
Member

mattab commented Dec 21, 2022

Based on @sgiehl assessment, i'm moving this out of the milestone.
Instead @lance-matomo @mattmary could you collaborate with the WP users who have this issue to reproduce the issue so we can understand the root cause and fix it?

@mattab mattab removed this from the 4.13.1 milestone Dec 21, 2022
@justinvelluppillai justinvelluppillai removed their assignment Dec 21, 2022
@MatomoForumNotifications

This issue has been mentioned on Matomo forums. There might be relevant details there:

https://forum.matomo.org/t/how-to-disable-confirmpassword-feature/49834/2

@mattab
Copy link
Member

mattab commented Mar 10, 2023

Because a workaround is available and documented here: #19904 (comment)

And because disabling this feature in theory shouldn't be required (and SAML / LDAP plugins handle it correctly) then we can close this issue I think. please comment or reopen if i missed something.

@mattab mattab closed this as not planned Won't fix, can't repro, duplicate, stale Mar 10, 2023
@sgiehl sgiehl added the wontfix If you can reproduce this issue, please reopen the issue or create a new one describing it. label May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. wontfix If you can reproduce this issue, please reopen the issue or create a new one describing it.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants