Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid escaping of characters other than " #19899

Closed
Findus23 opened this issue Oct 21, 2022 · 1 comment · Fixed by #19978
Closed

Avoid escaping of characters other than " #19899

Findus23 opened this issue Oct 21, 2022 · 1 comment · Fixed by #19978
Assignees
@sgiehl
Labels
Bug For errors / faults / flaws / inconsistencies etc. Regression Indicates a feature used to work in a certain way but it no longer does even though it should.
Milestone
4.12.4

Comments

@Findus23
Copy link
Member

Findus23 commented Oct 21, 2022 •
edited

When the MySQL password contains special characters (e.g. ') and a plugin is disabled (or presumably any other action is taken that modifies config.ini.php), some special characters get escaped with \' and Matomo breaks with a Database access denied as the password isn't correct anymore.

Matomo 4.12.1

This might be a bug in https://github.com/matomo-org/component-ini instead of Matomo itself and might be related to matomo-org/plugin-LoginLdap#308
@Findus23 Findus23 added Bug For errors / faults / flaws / inconsistencies etc. Potential Bug Something that might be a bug, but needs validation and confirmation it can be reproduced. labels Oct 21, 2022
@peterhashair
Copy link
Contributor

peterhashair commented Oct 24, 2022 •
edited

@Findus23 thanks for reporting this, I can reproduce this one locally, I will put this into the current milestone.

Notes this maybe related to this PR https://github.com/matomo-org/component-ini/pull/17/files.

@peterhashair peterhashair added Regression Indicates a feature used to work in a certain way but it no longer does even though it should. and removed Potential Bug Something that might be a bug, but needs validation and confirmation it can be reproduced. labels Oct 24, 2022
@peterhashair peterhashair added this to the 4.12.3 milestone Oct 24, 2022
@peterhashair peterhashair self-assigned this Oct 25, 2022
@peterhashair peterhashair mentioned this issue Oct 25, 2022
Closed
11 tasks
@peterhashair peterhashair assigned sgiehl and unassigned peterhashair Oct 26, 2022
@justinvelluppillai justinvelluppillai modified the milestones: 4.12.3, 4.12.4 Oct 27, 2022
@sgiehl sgiehl mentioned this issue Oct 27, 2022
Merged
11 tasks
@sgiehl sgiehl linked a pull request Nov 9, 2022 that will close this issue
[automatic composer updates] #19978
Merged
@sgiehl sgiehl mentioned this issue Nov 9, 2022
Merged
@elabuwa elabuwa changed the title Disabling plugins changes passwords in ini files Avoid escaping of characters other than " Nov 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sgiehl sgiehl

Labels
Bug For errors / faults / flaws / inconsistencies etc. Regression Indicates a feature used to work in a certain way but it no longer does even though it should.
Projects
None yet
Milestone
4.12.4
4 participants
@justinvelluppillai @sgiehl @peterhashair @Findus23