Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pg 820 pass segment #19890

Merged
merged 7 commits into from Oct 21, 2022
Merged

Pg 820 pass segment #19890

merged 7 commits into from Oct 21, 2022

Conversation

AltamashShaikh
Copy link
Contributor

Description:

Please include a description of this change and which issue it fixes. If no issue exists yet please include context and what problem it solves.

Review

@AltamashShaikh AltamashShaikh added the Needs Review PRs that need a code review label Oct 20, 2022
Copy link
Contributor

@bx80 bx80 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bx80 bx80 merged commit 9b15c89 into 5.x-dev Oct 21, 2022
@bx80 bx80 deleted the PG-820-pass-segment branch October 21, 2022 03:01
@AltamashShaikh
Copy link
Contributor Author

btw, this was already approved in 4.x-dev branch, and @tsteur there shouldn't be any notices

bx80 pushed a commit that referenced this pull request Nov 25, 2022
* Added support to pass segment in Archiving.getIdSitesToMarkArchivesAsInvalidated event, #PG-820

* Started passing dates,day and period paramters too

* Started passing the name parameter too

* built vue files

* Updated CHANGELOG.md

Co-authored-by: AltamashShaikh <AltamashShaikh@users.noreply.github.com>
bx80 pushed a commit that referenced this pull request Nov 25, 2022
* Added support to pass segment in Archiving.getIdSitesToMarkArchivesAsInvalidated event, #PG-820

* Started passing dates,day and period paramters too

* Started passing the name parameter too

* built vue files

* Updated CHANGELOG.md

Co-authored-by: AltamashShaikh <AltamashShaikh@users.noreply.github.com>
@sgiehl sgiehl added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label May 16, 2023
@sgiehl sgiehl added this to the 5.0.0 milestone May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants