Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure Tag Manager update are run on updates #19887

Closed
nicoco59 opened this issue Oct 19, 2022 · 8 comments
Closed

Ensure Tag Manager update are run on updates #19887

nicoco59 opened this issue Oct 19, 2022 · 8 comments
Assignees
@sgiehl
Labels
Potential Bug Something that might be a bug, but needs validation and confirmation it can be reproduced.
Milestone
4.12.3

Comments

@nicoco59
Copy link

Hi,

I'm currently having a problem showing the list of my tags in my tag manager, there is a javascript error and nothing is showing.

Here's the error I got :

TypeError: Cannot read properties of undefined (reading 'length')
at tagManagerHelper.truncateText (index.php?module=Proxy&action=getCoreJs&cb=dd3ee26d5cec01ecbb10a761a42c944f:2467:308)
at Proxy.truncateText (index.php?module=Proxy&action=getUmdJs&chunk=2&cb=dd3ee26d5cec01ecbb10a761a42c944f:100:8430)
at index.php?module=Proxy&action=getUmdJs&chunk=2&cb=dd3ee26d5cec01ecbb10a761a42c944f:100:3023
at e.renderList (index.php?module=Proxy&action=getCoreJs&cb=dd3ee26d5cec01ecbb10a761a42c944f:41:121877)
at index.php?module=Proxy&action=getUmdJs&chunk=2&cb=dd3ee26d5cec01ecbb10a761a42c944f:100:2684
at o (index.php?module=Proxy&action=getCoreJs&cb=dd3ee26d5cec01ecbb10a761a42c944f:41:14442)
at e.renderSlot (index.php?module=Proxy&action=getCoreJs&cb=dd3ee26d5cec01ecbb10a761a42c944f:41:122378)
at Proxy.Qn (index.php?module=Proxy&action=getUmdJs&chunk=0&cb=dd3ee26d5cec01ecbb10a761a42c944f:275:966)
at Dt (index.php?module=Proxy&action=getCoreJs&cb=dd3ee26d5cec01ecbb10a761a42c944f:41:14750)
at fe.fn (index.php?module=Proxy&action=getCoreJs&cb=dd3ee26d5cec01ecbb10a761a42c944f:41:40794)
(anonymous) @ index.php?module=Proxy&action=getCoreJs&cb=dd3ee26d5cec01ecbb10a761a42c944f:41

Before it happened I set a tag for an A/B test and maybe the script I copy / pasted in one of the tag was too big.

Thanks in advance for your help.
@nicoco59 nicoco59 added the Potential Bug Something that might be a bug, but needs validation and confirmation it can be reproduced. label Oct 19, 2022
@thesakshidiggikar
Copy link

hello! I would like to work on this issue could you please assign me this work, please...

@MrCodeB2
Copy link

Maybe this issue is connected to mine which occurs since the update from 4.12.0 to 4.12.1

Within my tag manager container i can only see items in the Dashboard. When trying to open triggers or tags i get an empty view back (see screenshots).

When trying to create a new trigger (-> Dashboard-> Create new trigger) i get an error when trying to save the trigger saying
SQLSTATE[42S22]: Column not found: 1054 Unknown column 'description' in 'field list'

Seems like a bug in the database upgrade?

firefox_MptdbsI4nA
firefox_Vb0oxjidRs
firefox_tBJtAVoYNs

@AltamashShaikh
Copy link
Contributor

@nicoco59 @MrCodeB2
Can you check this issue ?

@nicoco59
Copy link
Author

nicoco59 commented Oct 20, 2022 •
edited

I asked my server host to solve the issue with "SQLSTATE[42S22]: Column not found: 1054 Unknown column 'description' in 'field list'" as I got it as well.

It seems I can update tags again now, but I still can't see the list of tags (triggers as well btw), they're investing the problem right now, and of course there is no fallback if I disable javascript.

I'm doing two big A / B tests at the moment, and the HTML code that was generated was quite big, so I was wondering if it's not what caused the error in the first place.

That's quite problematic because I have to stop one A/B test very soon and I just can't from the Tag Manager.

@MrCodeB2
Copy link

@AltamashShaikh thank you, worked like a charm

@nicoco59
Copy link
Author

The fix above didn't help us, however we found another way to fix it :

After investigation, a column "description" has been added with 3 tables since the last update (4.12.1).
However by looking at the tables, a bug occured during the creation.

The column "description" should have been added after the the column "name" and the content shouldn't be "NULL".
Instead of this, the column "description" has been added as the last column and the content of every entry was "NULL".

Here are the steps to solve this issue :

Backup the tables which are causing the issues
Delete the column "description"
Recreate the column "description"

It's working and I can see the tags again in the Tag Manager.

@heurteph-ei heurteph-ei mentioned this issue Oct 20, 2022
Closed
@MatomoForumNotifications
Copy link

This issue has been mentioned on Matomo forums. There might be relevant details there:

https://forum.matomo.org/t/tags-and-triggers-are-no-longer-displayed/47984/3

@MahmutTu
Copy link

This issue has been fixed for me with release 4.12.3

@sgiehl sgiehl closed this as completed Oct 27, 2022
@elabuwa elabuwa changed the title Can't show list of tags in the tag manager Ensure Tag Manager update are run on updates Nov 22, 2022
@sgiehl sgiehl added this to the 4.12.3 milestone May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sgiehl sgiehl

Labels
Potential Bug Something that might be a bug, but needs validation and confirmation it can be reproduced.
Projects
None yet
Milestone
4.12.3
Development

No branches or pull requests
7 participants
@sgiehl @nicoco59 @AltamashShaikh @MahmutTu @MrCodeB2 @thesakshidiggikar @MatomoForumNotifications