@AltamashShaikh opened this Pull Request on October 18th 2022 Contributor

Description:

Added support to pass segment in Archiving.getIdSitesToMarkArchivesAsInvalidated event.
Fixes: #PG-820

Review

@tsteur commented on October 20th 2022 Member

Just seeing this was merged into 4.x-dev. Not sure if it was supposed to be merged into 5.x-dev see also the changelog entry in this PR and if this can cause any notices/regression or so regarding the additional parameter in the event?

@AltamashShaikh commented on October 20th 2022 Contributor

@tsteur My bad I opened the PR to be merged in 4.x-dev, what should we do here ?
Open a new PR for 5.x ?

@tsteur commented on October 20th 2022 Member

Ideally we would revert the PR. There's a button to do this easily

image
This Pull Request was closed on October 20th 2022
Powered by GitHub Issue Mirror