Added support to pass segment in Archiving.getIdSitesToMarkArchivesAsInvalidated event #19876
Conversation
…Invalidated event, #PG-820
core/Archive/ArchiveInvalidator.php
Outdated
| @@ -310,7 +310,7 @@ public function markArchivesAsInvalidated(array $idSites, array $dates, $period, | |||
| * | |||
| * @param array &$idSites An array containing a list of site IDs which are requested to be invalidated. | |||
| */ | |||
| Piwik::postEvent('Archiving.getIdSitesToMarkArchivesAsInvalidated', array(&$idSites)); | |||
| Piwik::postEvent('Archiving.getIdSitesToMarkArchivesAsInvalidated', array(&$idSites, $segment)); | |||
There was a problem hiding this comment.
Passing only the segment here actually looks a bit random. Why not also passing the dates, period or the name. Might all be something that could be relevant in some cases.
Also when updating events, you should update the comment above, so it describes all parameters. And it might be good to mention the change in the changelog, so developers are aware of it.
There was a problem hiding this comment.
@sgiehl Started passing dates, period, segment and name parameter as suggested.
Also updated CHANGELOG.md please check if that't the correct way to update it.
There was a problem hiding this comment.
- Functional review done
- Potential edge cases thought about (behavior of the code with strange input, with strange internal state or possible interactions with other Matomo subsystems)
- Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
- Security review done
- Wording review done
- Code review done
- Not useful Tests were added if useful/possible
- Reviewed for breaking changes
- Updated Developer changelog updated if needed
- n/a Documentation added if needed
- n/a Existing documentation updated if needed
|
Just seeing this was merged into 4.x-dev. Not sure if it was supposed to be merged into |
|
@tsteur My bad I opened the PR to be merged in |
|
Ideally we would revert the PR. There's a button to do this easily |
sgiehl
added
the
not-in-changelog
Description:
Added support to pass segment in Archiving.getIdSitesToMarkArchivesAsInvalidated event.
Fixes: #PG-820
Review