Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update autocomplete values #19872

Closed
Starker3 opened this issue Oct 17, 2022 · 1 comment · Fixed by #19873
Closed

Update autocomplete values #19872

Starker3 opened this issue Oct 17, 2022 · 1 comment · Fixed by #19873
Assignees
@peterhashair
Labels
Potential Bug Something that might be a bug, but needs validation and confirmation it can be reproduced. Regression Indicates a feature used to work in a certain way but it no longer does even though it should.
Milestone
4.12.4

Comments

@Starker3
Copy link
Contributor

In Matomo 4.12.0 it looks as though some fields are being auto filled by browser or browser extensions with the username.
For example in the Measurables admin area browser autofill now enters the username in the search field:
image

I tested this in 4.11.0 and the behaviour was not the same, but after updating to 4.12.0 my browser password manager extension could auto fill the search bar with a username. I've tested a few different places where a search bar or input field is present and it seems to only affect the search input in the measurables.

This would mainly be an issue where people have browsers or extensions configured to autofill without interaction.
@Starker3 Starker3 added the Potential Bug Something that might be a bug, but needs validation and confirmation it can be reproduced. label Oct 17, 2022
@peterhashair
Copy link
Contributor

Looks like there is a regression here autocomplete="false", should be autocomplete="off".

@peterhashair peterhashair mentioned this issue Oct 17, 2022
Merged
11 tasks
@justinvelluppillai justinvelluppillai added this to the 4.12.3 milestone Oct 25, 2022
@justinvelluppillai justinvelluppillai added the Regression Indicates a feature used to work in a certain way but it no longer does even though it should. label Oct 25, 2022
@peterhashair peterhashair self-assigned this Oct 26, 2022
@justinvelluppillai justinvelluppillai modified the milestones: 4.12.3, 4.12.4 Oct 27, 2022
@elabuwa elabuwa changed the title Some search input fields are being populated by user/password autofill Update autocomplete values Nov 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@peterhashair peterhashair

Labels
Potential Bug Something that might be a bug, but needs validation and confirmation it can be reproduced. Regression Indicates a feature used to work in a certain way but it no longer does even though it should.
Projects
None yet
Milestone
4.12.4
Development

Successfully merging a pull request may close this issue.

update autocomplete on html to on and off matomo-org/matomo
3 participants
@justinvelluppillai @peterhashair @Starker3