Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failures link to Learn More #19870

Merged
merged 1 commit into from Oct 18, 2022
Merged

Conversation

PabloCastellano
Copy link
Contributor

Extra colon (:href) prevents clicking on the link in Chromium.

<a rel="noopener noreferrer" :href="https://matomo.org/faq/how-to/faq_30838/">Learn more</a>

Removed extra colon
@sgiehl sgiehl added the Needs Review PRs that need a code review label Oct 17, 2022
@sgiehl sgiehl added this to the 4.12.1 milestone Oct 17, 2022
@sgiehl sgiehl added the Regression Indicates a feature used to work in a certain way but it no longer does even though it should. label Oct 17, 2022
Copy link
Contributor

@bx80 bx80 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well for me 👍

@bx80 bx80 merged commit 9a3b202 into matomo-org:4.x-dev Oct 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review PRs that need a code review Regression Indicates a feature used to work in a certain way but it no longer does even though it should.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants