Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix array to string conversion warning in userOptOut #19858

Merged
merged 1 commit into from Oct 14, 2022
Merged

Fix array to string conversion warning in userOptOut #19858

merged 1 commit into from Oct 14, 2022

Conversation

bx80
Copy link
Contributor

@bx80 bx80 commented Oct 14, 2022

Description:

Fixes an array to string conversion bug caused by variable naming collision.

Fixes #19852

Review

@bx80 bx80 added the Regression Indicates a feature used to work in a certain way but it no longer does even though it should. label Oct 14, 2022
@bx80 bx80 added this to the 4.12.1 milestone Oct 14, 2022
@bx80 bx80 self-assigned this Oct 14, 2022
@bx80 bx80 added Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. labels Oct 14, 2022
@sgiehl sgiehl removed the Needs Review PRs that need a code review label Oct 14, 2022
@sgiehl sgiehl merged commit 57b60d9 into 4.x-dev Oct 14, 2022
@sgiehl sgiehl deleted the m19852-fix-array-string-conversion branch October 14, 2022 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgiehl sgiehl sgiehl approved these changes

Assignees

@bx80 bx80

Labels
not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Regression Indicates a feature used to work in a certain way but it no longer does even though it should.
Projects
None yet
Milestone
4.12.1
Development

Successfully merging this pull request may close these issues.

Fix array to string conversion warning in userOptOut
2 participants
@bx80 @sgiehl