Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Goal visits log query performance improvement - don't execute the query when no idVisits #19853

Merged
merged 1 commit into from Oct 13, 2022

Conversation

tsteur
Copy link
Member

@tsteur tsteur commented Oct 13, 2022

We earlier so a high CPU usage on database which seems to have happened because there were maybe on idvisits given

... WHERE log_conversion.idvisit IN ('') ...

Review

… idVisits given

We earlier so a high CPU usage on database which seems to have happened because there were maybe on idvisits given

```
... WHERE log_conversion.idvisit IN ('') ...
```
@tsteur tsteur added the Needs Review PRs that need a code review label Oct 13, 2022
@tsteur tsteur added this to the 4.12.1 milestone Oct 13, 2022
Copy link
Member

@sgiehl sgiehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense

@sgiehl sgiehl merged commit 582b76b into 4.x-dev Oct 13, 2022
@sgiehl sgiehl deleted the goalsvisitslog branch October 13, 2022 07:35
@justinvelluppillai justinvelluppillai changed the title Goal visits log query: No need to execute the query when there are no idVisits given Goal visits log query performance improvement - don't execute the query when no idVisits Oct 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review PRs that need a code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants