Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Semver dependency #19846

Closed
SOMERSOFTAndrewCrook opened this issue Oct 11, 2022 · 4 comments · Fixed by #19934
Closed

Update Semver dependency #19846

SOMERSOFTAndrewCrook opened this issue Oct 11, 2022 · 4 comments · Fixed by #19934
Assignees
@sgiehl
Milestone
4.13.0

Comments

@SOMERSOFTAndrewCrook
Copy link

In composer.json it has the line

        "composer/semver": "~1.3.0",

and in composer.lock

            "name": "composer/semver",
            "version": "1.3.0",
            "source": {
                "type": "git",
                "url": "https://github.com/composer/semver.git",
                "reference": "df4463baa9f44fe6cf0a6da4fde2934d4c0a2747"
            },
            "dist": {
                "type": "zip",
                "url": "https://api.github.com/repos/composer/semver/zipball/df4463baa9f44fe6cf0a6da4fde2934d4c0a2747",
                "reference": "df4463baa9f44fe6cf0a6da4fde2934d4c0a2747",
                "shasum": ""
            },
            "require": {
                "php": "^5.3.2 || ^7.0"
            },

This commit Added support for php8 indicated it was introduced with verison3.3.2.

Expected Behavior

Should be able to composer install when using using PHP 8.

Current Behavior

semver is is flagged as incompatible.

Possible Solution

Update composer.json

        "composer/semver": ">=3.3.2",

Steps to Reproduce (for Bugs)

Context

Your Environment

  • Matomo Version:
  • PHP Version: 8.1
  • Server Operating System:
  • Additionally installed plugins:
  • Browser:
  • Operating System:
@SOMERSOFTAndrewCrook SOMERSOFTAndrewCrook added the Potential Bug Something that might be a bug, but needs validation and confirmation it can be reproduced. label Oct 11, 2022
@sgiehl
Copy link
Member

sgiehl commented Oct 11, 2022

We are actually only using the VersionParser, which seems to run on all versions. At least we don't have any issues when running tests on PHP 8.1.
I think this might be something we could consider doing as part of Matomo 5. ping @justinvelluppillai

@sgiehl sgiehl added this to the For Prioritization milestone Oct 11, 2022
@sgiehl sgiehl removed the Potential Bug Something that might be a bug, but needs validation and confirmation it can be reproduced. label Oct 11, 2022
@SOMERSOFTAndrewCrook
Copy link
Author

@sgiehl Thank you for the reply, could it be a part of 4.12.1 release? It would interesting to find out how many sites use the composer install to build the application.

@sgiehl
Copy link
Member

sgiehl commented Oct 13, 2022

We most likely won't update vendor libs with patch releases. Also installing Matomo using composer is not the recommended way to use it, so I don't think many people are doing that. At least we did not yet get any similar report.

@jackd248
Copy link

jackd248 commented Nov 1, 2022

We get the same problem here, want to try to install matomo via composer and run the application with php 8.
Is it possible to fix this issue while allowing composer/semver 1.7.2?
https://packagist.org/packages/composer/semver#1.7.2

@sgiehl sgiehl mentioned this issue Nov 2, 2022
Merged
11 tasks
@elabuwa elabuwa changed the title composer/semver is fixed at 1.3 which is not PHP 8 compatible . Update Semver dependency Nov 22, 2022
@sgiehl sgiehl modified the milestones: For Prioritization, 4.13.0 May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sgiehl sgiehl

Labels
None yet
Projects
None yet
Milestone
4.13.0
Development

Successfully merging a pull request may close this issue.

Updates semver dependency matomo-org/matomo
3 participants
@sgiehl @jackd248 @SOMERSOFTAndrewCrook