@peterhashair opened this Pull Request on October 10th 2022 Contributor

Description:

Fixes: #17017
add file:// protocol exclude option in the tracker

add _paq.push(['enableFileTracking']); will start track protocal file:

Review

@peterhashair commented on October 10th 2022 Contributor

Not too sure if we can write a test for that feature, to change window.location.protocal maybe a problem.

@peterhashair commented on October 13th 2022 Contributor

@sgiehl just checking, if that is the right solution.

@sgiehl commented on October 14th 2022 Member

@peterhashair what should your PR provide? Currently it adds a config option, that can be changed. But the option is not having any effect, so it's kind of useless 🤔

@peterhashair commented on October 16th 2022 Contributor

@sgiehl I thought this would escape the tracking.


                if (!configFileTracking && windowAlias.location.protocol === 'file:') {
                    configDoNotTrack = true;
                }
@sgiehl commented on October 16th 2022 Member

@sgiehl I thought this would escape the tracking.


                if (!configFileTracking && windowAlias.location.protocol === 'file:') {
                    configDoNotTrack = true;
                }

Isn't that variable responsible for something completely different? Didn't have look right now, but iirc that should be the config flag responsible for checking "do-not-track" headers in the browser.

@github-actions[bot] commented on November 1st 2022 Contributor

If you don't want this PR to be closed automatically in 28 days then you need to assign the label 'Do not close'.

@peterhashair commented on November 3rd 2022 Contributor

build js

@justinvelluppillai commented on November 24th 2022 Member

@peterhashair did you see/action @Findus23 comment re updating the changelog with this?

@peterhashair commented on November 24th 2022 Contributor

@justinvelluppillai will update changelog shortly

This Pull Request was closed on November 3rd 2022
Powered by GitHub Issue Mirror