Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow empty excludedReferrers on the global setting #19833

Closed
Findus23 opened this issue Oct 9, 2022 · 3 comments · Fixed by #19834
Closed

Allow empty excludedReferrers on the global setting #19833

Findus23 opened this issue Oct 9, 2022 · 3 comments · Fixed by #19834
Assignees
@peterhashair
Labels
Bug For errors / faults / flaws / inconsistencies etc. Regression Indicates a feature used to work in a certain way but it no longer does even though it should.
Milestone
4.12.1

Comments

@Findus23
Copy link
Member

Findus23 commented Oct 9, 2022 •
edited

reported in https://forum.matomo.org/t/the-address-is-not-a-valid-url/47725 and reproduced on 4.12.0

If e.g. the "Global list of excluded referrers" is empty, the form can't be saved:
grafik

related to #19302
@Findus23 Findus23 added Bug For errors / faults / flaws / inconsistencies etc. Regression Indicates a feature used to work in a certain way but it no longer does even though it should. labels Oct 9, 2022
@Findus23 Findus23 added this to the 4.12.1 milestone Oct 9, 2022
@MatomoForumNotifications
Copy link

This issue has been mentioned on Matomo forums. There might be relevant details there:

https://forum.matomo.org/t/the-address-is-not-a-valid-url/47725/3

@WM-Loose
Copy link

WM-Loose commented Oct 9, 2022

on all installations after update the same problem!

@peterhashair peterhashair self-assigned this Oct 9, 2022
@peterhashair
Copy link
Contributor

Quickly did a PR for this one, just wondering, once the global setting is successfully saved, should we show a success notification on the top?

@peterhashair peterhashair mentioned this issue Oct 9, 2022
Merged
11 tasks
@Findus23 Findus23 mentioned this issue Oct 12, 2022
Closed
@justinvelluppillai justinvelluppillai changed the title "The url '' is not a valid URL" when trying to save empty Global websites settings Allow empty excludedReferrers on the global setting Oct 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@peterhashair peterhashair

Labels
Bug For errors / faults / flaws / inconsistencies etc. Regression Indicates a feature used to work in a certain way but it no longer does even though it should.
Projects
None yet
Milestone
4.12.1
Development

Successfully merging a pull request may close this issue.

Allow empty excludedReferrers on the global setting matomo-org/matomo
4 participants
@peterhashair @Findus23 @MatomoForumNotifications @WM-Loose