add convenience command to minify tracker JS during development #19830
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…UICompressor instructions), for core or a plugin.
|
@diosmosis might be worth mentioning this command in https://github.com/matomo-org/matomo/blob/de5ae85e7a11f7bbd962256c890a32188c40d000/js/README.md |
|
@sgiehl done |
sgiehl
approved these changes
Oct 10, 2022
bx80
pushed a commit
that referenced
this pull request
Nov 25, 2022
* Add command to minify tracker JS during development (using existing YUICompressor instructions), for core or a plugin. * Add docs in js/README.md for build-tracker-js command
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
I'm working on a plugin that has some custom tracker JS code and noticed there's no instructions for minifying tracker JS. So I wrote this command which uses the instructions for minifying the core tracker JS to minify either that file, or the tracker JS for a plugin. Mostly for convenience.
Review