Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Abstract locking functions to allow support for additional database engines #19828

Closed
wants to merge 1 commit into from
Closed

Abstract locking functions to allow support for additional database engines #19828

wants to merge 1 commit into from

Conversation

bx80
Copy link
Contributor

@bx80 bx80 commented Oct 6, 2022

Description:

Abstracts all code that performs database locking to use functions defined in AdapterInterface which are then implemented separately in individual database adapter classes. This will allow different database engines to handle locking in their own way and remove the assumption that MySQL locking is being used.

Fixes #19643

Review

@bx80
Abstract get_lock, release_lock, lockTables, unlockAllTables and isLo…
ed76a62 
…ckAvailable functions to the database adapters
@bx80 bx80 added Major Indicates the severity or impact or benefit of an issue is much higher than normal but not critical. Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change. labels Oct 6, 2022
@bx80 bx80 added this to the 5.0.0 milestone Oct 6, 2022
@bx80 bx80 self-assigned this Oct 6, 2022
@github-actions
Copy link
Contributor

If you don't want this PR to be closed automatically in 28 days then you need to assign the label 'Do not close'.

@github-actions github-actions bot added the Stale The label used by the Close Stale Issues action label Oct 21, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Dec 3, 2022

This PR was last updated more than one month ago, maybe it's time to close it. Please check if there is anything we still can do or close this PR. ping @matomo-org/core-reviewers

@github-actions github-actions bot added the Stale for long The label used by the Close Stale Issues action label Dec 3, 2022
@mattab mattab added the 5.0.0 label Jan 4, 2023
@sgiehl sgiehl modified the milestones: 5.0.0, 5.1.0 Jun 20, 2023
@sgiehl sgiehl added Do not close PRs with this label won't be marked as stale by the Close Stale Issues action and removed Stale The label used by the Close Stale Issues action Stale for long The label used by the Close Stale Issues action 5.0.0 labels Jul 10, 2023
@bx80 bx80 removed the Do not close PRs with this label won't be marked as stale by the Close Stale Issues action label Oct 1, 2023
@bx80
Copy link
Contributor Author

bx80 commented Oct 1, 2023

Closing this as it's now too old.

@bx80 bx80 closed this Oct 1, 2023
@sgiehl sgiehl deleted the m19643-abstract-db-lock branch January 9, 2024 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@bx80 bx80

Labels
Major Indicates the severity or impact or benefit of an issue is much higher than normal but not critical. Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change.
Projects
None yet
Milestone
5.1.0
Development

Successfully merging this pull request may close these issues.

Abstract database get_lock to the current PDO adapter
3 participants
@bx80 @mattab @sgiehl