Return correct parameter divId for JS opt-out #19827
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @DevDavido. Thanks for providing this fix 🎉 |
sgiehl
approved these changes
Oct 7, 2022
|
@sgiehl this will need to be merged to |
|
@justinvelluppillai That doesn't make too much sense, as actually everything in 4.x-dev should be included in 4.12.1 |
|
My understanding is that 4.x-dev has commits that next_release and 4.12.0 don't. 4.x-dev would be merged to 5.x-dev at some point. 4.12.1 will be created off next_release |
|
@justinvelluppillai There shouldn't be anything in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Generated JS opt-out code from Administration -> Privacy -> Users opt-out returns incorrect parameter
divinsteaddivId.Review