Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4.12.0 file integrity fail #19826

Closed
n2N8Z opened this issue Oct 6, 2022 · 5 comments
Closed

4.12.0 file integrity fail #19826

n2N8Z opened this issue Oct 6, 2022 · 5 comments
Labels
duplicate For issues that already existed in our issue tracker and were reported previously.

Comments

@n2N8Z
Copy link

n2N8Z commented Oct 6, 2022

Expected Behavior

When there was no file integrity issue before an upgrade, there should not be one afterward.

Current Behavior

After 4.12.0 upgrade there are 3 files that are flagged as not expected.

Files were found in your Matomo, but we didn't expect them.
--> Please delete these files to prevent errors. <--

File to delete: vendor/matomo/matomo-php-tracker/run_tests.sh
File to delete: vendor/phpmailer/phpmailer/language/phpmailer.lang-ch.php
File to delete: vendor/geoip2/geoip2/.php-cs-fixer.php


To delete all these files at once, you can run this command:
rm "/var/www/matomo/vendor/matomo/matomo-php-tracker/run_tests.sh" "/var/www/matomo/vendor/phpmailer/phpmailer/language/phpmailer.lang-ch.php" "/var/www/matomo/vendor/geoip2/geoip2/.php-cs-fixer.php"

Steps to Reproduce (for Bugs)

  1. Have 4.11.0 installed.
  2. Install 4.12.0 over the top.

Your Environment

  • Matomo Version: 4.12.0
  • PHP Version: 8.1.10
  • Server Operating System: CentOS Linux release 7.9.2009 (Core)
  • Additionally installed plugins:
#### Plugins Activated:
 API, Actions, Annotations, Bandwidth 4.0.2, BulkTracking, Contents, CoreAdminHome, CoreConsole, CoreHome, CorePluginsAdmin, CoreUpdater, CoreVisualizations, CoreVue, CustomDimensions, CustomJsTracker, Dashboard, DevicePlugins, DevicesDetection, Diagnostics, Ecommerce, Events, Feedback, FlagCounter 4.0.0, GeoIp2, Goals, GroupPermissions 4.0.5, Heartbeat, IPReports 4.2.0, ImageGraph, Insights, Installation, Intl, IntranetMeasurable, KPIWidgets 1.1.1, LanguagesManager, Live, LiveTab 4.0.1, LogViewer 4.1.1, Login, Marketplace, MobileMessaging, Monolog, Morpheus, MultiSites, Overlay, PagePerformance, PrivacyManager, ProfessionalServices, Proxy, Referrers, Resolution, RssWidget, SEO, ScheduledReports, SegmentEditor, SitesManager, TasksTimetable 4.0.2, Tour, Transitions, TwoFactorAuth, UserCountry, UserCountryMap, UserId, UserLanguage, UsersManager, VisitFrequency, VisitTime, VisitorInterest, VisitsSummary, WebsiteMeasurable, Widgetize
@n2N8Z n2N8Z added the Potential Bug Something that might be a bug, but needs validation and confirmation it can be reproduced. label Oct 6, 2022
@Findus23
Copy link
Member

Findus23 commented Oct 6, 2022

This might be related to #18435

@n2N8Z
Copy link
Author

n2N8Z commented Oct 6, 2022

This might be related to #18435

Yeah sounds the same. Two of the files in this case seem useful though (run_tests.sh, phpmailer.lang-ch.php).

@sgiehl
Copy link
Member

sgiehl commented Oct 7, 2022

@n2N8Z I'll close this as duplicate for now.
The files you mentioned can be deleted safely.

@sgiehl sgiehl closed this as not planned Won't fix, can't repro, duplicate, stale Oct 7, 2022
@sgiehl sgiehl added duplicate For issues that already existed in our issue tracker and were reported previously. and removed Potential Bug Something that might be a bug, but needs validation and confirmation it can be reproduced. labels Oct 7, 2022
@n2N8Z
Copy link
Author

n2N8Z commented Oct 10, 2022

While I agree the cause is the same as #18435, but what is the resolution to the specific files that are flagged in 4.12.0, can they really be deleted without impacting any functionality ?

@sgiehl
Copy link
Member

sgiehl commented Oct 10, 2022

The files you have mentioned in the issue description can be removed safely.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate For issues that already existed in our issue tracker and were reported previously.
Projects
None yet
Development

No branches or pull requests

3 participants