Ensure plugin updates are executed when setting up UITestFixture #19825
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgiehl
added
c: Tests & QA
bx80
approved these changes
Oct 16, 2022
There was a problem hiding this comment.
Tested by adding breakpoints to plugin install() methods and then running integration tests 👍
- Functional review done
- Potential edge cases thought about (behavior of the code with strange input, with strange internal state or possible interactions with other Matomo subsystems)
- Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
- Security review done
- n/a Wording review done
- Code review done
- Tests were added if useful/possible
- None Reviewed for breaking changes
- n/a Developer changelog updated if needed
- n/a Documentation added if needed
- n/a Existing documentation updated if needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Currently when setting up the UITestFixture, updates for plugin are not executed.
That is caused by resetting the details about which plugins are installed and trying to install them again.
If an update e.g. modified a table, installing the table again won't update it. But as the installed plugin version will be updated to the latest version after it was installed, update script won't be executed afterwards.
Preserving the database information which version was installed when database dump was created fixes this.
For some reason doing that only runs into a PHP segfault when executing the updates.
Disabling the events while performing such updates solves that problem.
When merging such changes to 5.x-dev, we should consider reverting the database changes in the fixture done in #19746
Review