Ensure empty tables also use max width #19822
Conversation
sgiehl
added
not-in-changelog
|
fyi not sure if related to this: It might make the evolution graph smaller yet not the sparklines. The evolution graph I believe should still have full width even when there's no data |
|
@tsteur I guess that was already the case before and should be unrelated to the fact if there is data or not. I've pushed a commit, so evolution charts aren't resized. Let's see if there are some screenshot changes due to that... |
|
@sgiehl just fyi I don't think this wasn't the case previously. I'm looking at some reports without this patch on production where it has zero data and the graph is shown full width. |
|
@tsteur nvm. my last commit should have fixed that. |
There was a problem hiding this comment.
Looks good to me, @tsteur it's that ok to merge that update for empty table width?
- Functional review done
- Potential edge cases thought about (behavior of the code with strange input, with strange internal state or possible interactions with other Matomo subsystems)
- Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
- Security review done
- Wording review done
- Code review done
- Tests were added if useful/possible
- Reviewed for breaking changes
- Developer changelog updated if needed
Description:
fixes #19819
Review