Detect consent manager and suggest guide #19821
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…guration guide link
…mail these instuctions' button, add consent manager link to instructions email, add link to the privacy 'asking for consent' page
bx80
added
the
Enhancement
|
If you don't want this PR to be closed automatically in 28 days then you need to assign the label 'Do not close'. |
github-actions
bot
added
the
Stale
bx80
added
Needs Review
…or site content test data, added UI tests for consent manager detection
…ect-consent-manager
11 tasks
# Conflicts: # plugins/SitesManager/Controller.php # plugins/SitesManager/templates/_siteWithoutDataTabs.twig # plugins/SitesManager/templates/_trackingCodeEmail.twig # tests/PHPUnit/Fixtures/EmptySiteWithSiteContentDetection.php
…ect-consent-manager
…ed UI test screenshot
peterhashair
approved these changes
Nov 14, 2022
There was a problem hiding this comment.
Looks good to me
- Functional review done
- Potential edge cases thought about (behavior of the code with strange input, with strange internal state or possible interactions with other Matomo subsystems)
- Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
- Security review done
- Wording review done
- Code review done
- Tests were added if useful/possible
- Reviewed for breaking changes
- Developer changelog updated if needed
- Documentation added if needed
elabuwa
added
the
not-in-changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Follows on from #19794
Ref: DEV-3004
The specification has changed to have a 'Become an expert...' challenge instead of a link on the Getting Started page.
A guide link will be added to 'Email these instructions' email if a consent manager is detected.
The Administration > Privacy > Asking for Consent section will also show a link to the consent manager guide if detected.
Review