New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Trunk: delete the piwik_ignore cookie via UI doesn't work #1982
Comments
I'll take a look. It was working for me in FF when it was a separate plugin. |
Using User Settings > Ignore Cookie, I can create but not delete the cookie. Using ?module=CoreAdminHome&action=optOut I can opt out, opt in, then I can't opt out again (it just refreshes the page) with "You are currently opted in" message before/after. The cookie is Name piwik_ignore |
I think you're running into the "resend form?" problem because the browser thinks you're trying to re-POST. Not sure what browser setting controls this, but I toggled it a dozen times. What happens if you add this to optOut.tpl?
|
adding the line doesnt fix it I cant remove the cookie also using the ' Click here to delete the cookie and have Piwik track your visits' link in Settings>User settings, which was working before (is it working for you?) |
(In [3692]) refs #1982 - Smarty default is to passthrough php tag as plain text; use built-in smarty.now |
Both UserSettings.setIgnoreCookie and CoreAdminHome.optOut worked for me. See if [3692] helps in your case using optOut. I'm not sure about UserSettings. The only difference is that it's a GET, and there's a Location: (redirect) and Set-Cookie: in the response. |
(In [3815]) refs #1982 - delete() should use setCookie() instead of setcookie(), and pass path + domain. |
matt: please svn up and test |
I tried, when I click delete the ignore cookie, I see the http response: Set-Cookie piwik_ignore=deleted; expires=Fri, 05-Feb-2010 00:11:09 GMT but then the following request still has the cookie. I have the same problem with optout feature. |
Replying to matt:
I'm pretty sure that's the old code calling the built-in setcookie() function. Maybe there was a merge conflict with Cookie.php?
Another possibility is duplicate cookies in your browser. Did you previously install Piwik in a parent directory? (Cookies are uniquely identified by the tuple, (name, domain, path). |
(In [3853]) refs #1982 - when deleting cookie, mimic the built-in function php/ext/standard/head.c has this comment:
|
Delete the cookies manually in your browser and svn up. The http response in comment:11 shows that your working copy doesn't have the change from [3815]. |
OK Anthon you were right, my merge/update didn't complete for some reasons. Now all is working, great news. |
on FF and Chrome at least, setting the cookie works, but deleting doesn't work. I looked but didn't see the solution (Piwik_Tracker_Cookie::setIgnoreCookie goes through ->delete() so not sure what is not working?)
The text was updated successfully, but these errors were encountered: