Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TourEngagement accessibility improvement - Remove redundant information #19809

Merged
merged 1 commit into from Oct 13, 2022

Conversation

audrasjb
Copy link
Contributor

@audrasjb audrasjb commented Oct 3, 2022

Description:

This PR is related to issue #19807.

Currently, in the tourEngagement widget, there is a redundant text resulting in duplicate information for non sighted users. This adds a lot of noise to assistive technologies rendering.

First we have this:

    <p title="{{ 'Tour_StatusLevel'|translate(level.currentLevelName, level.challengesNeededForNextLevel, level.nextLevelName)|e('html_attr') }}">

Followed by:

        <p>
            {{ 'Tour_StatusLevel'|translate('<strong>'~ level.currentLevelName ~'</strong>', level.challengesNeededForNextLevel, '<strong>'~ level.nextLevelName ~'</strong>')|raw }}
        </p>

We should simply remove the title of the first occurrence, as the same exact text appears right after.

This changeset also adds aria-hidden="true" to the star-icons paragraph.

Review

@sgiehl sgiehl added Needs Review PRs that need a code review c: Accessibility When something is not usable for a certain group (eg missing contrast) or devices (eg smartphones). labels Oct 5, 2022
@github-actions
Copy link
Contributor

This issue is in "needs review" but there has been no activity for 7 days. ping @matomo-org/core-reviewers

@github-actions github-actions bot added the Stale The label used by the Close Stale Issues action label Oct 13, 2022
@sgiehl sgiehl merged commit 2740edb into matomo-org:4.x-dev Oct 13, 2022
@sgiehl sgiehl removed Needs Review PRs that need a code review Stale The label used by the Close Stale Issues action labels Oct 13, 2022
@sgiehl sgiehl added this to the 4.12.1 milestone Oct 13, 2022
@justinvelluppillai justinvelluppillai changed the title TourEngagement: Remove redundant information for better a11y. TourEngagement accessibility improvement - Remove redundant information Oct 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: Accessibility When something is not usable for a certain group (eg missing contrast) or devices (eg smartphones).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants