@audrasjb opened this Pull Request on October 3rd 2022 Contributor

Description:

This PR is related to issue #19807.

Currently, in the tourEngagement widget, there is a redundant text resulting in duplicate information for non sighted users. This adds a lot of noise to assistive technologies rendering.

First we have this:

    <p title="{{ 'Tour_StatusLevel'|translate(level.currentLevelName, level.challengesNeededForNextLevel, level.nextLevelName)|e('html_attr') }}">

Followed by:

        <p>
            {{ 'Tour_StatusLevel'|translate('<strong>'~ level.currentLevelName ~'</strong>', level.challengesNeededForNextLevel, '<strong>'~ level.nextLevelName ~'</strong>')|raw }}
        </p>

We should simply remove the title of the first occurrence, as the same exact text appears right after.

This changeset also adds aria-hidden="true" to the star-icons paragraph.

Review

@github-actions[bot] commented on October 13th 2022 Contributor

This issue is in "needs review" but there has been no activity for 7 days. ping @matomo-org/core-reviewers

This Pull Request was closed on October 13th 2022
Powered by GitHub Issue Mirror