Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visits Overview accessibility improvement - remove redundant information #19808

Merged
merged 1 commit into from Oct 13, 2022

Conversation

audrasjb
Copy link
Contributor

@audrasjb audrasjb commented Oct 3, 2022

This PR is related to issue #19807.

Description:

On several places of the admin, assistive technologies users will get redundant information due to duplicate info between text and title attributes, etc.

This PR aims to fix this issue on the Visites Overview widget.

Review

@sgiehl sgiehl added the Needs Review PRs that need a code review label Oct 5, 2022
@github-actions
Copy link
Contributor

This issue is in "needs review" but there has been no activity for 7 days. ping @matomo-org/core-reviewers

@github-actions github-actions bot added the Stale The label used by the Close Stale Issues action label Oct 13, 2022
Copy link
Member

@sgiehl sgiehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not very familiar with a11y, but if this small change improves it, I can't see any reason why we shouldn't apply it.

@sgiehl sgiehl added this to the 4.12.1 milestone Oct 13, 2022
@sgiehl sgiehl added c: Accessibility When something is not usable for a certain group (eg missing contrast) or devices (eg smartphones). and removed Needs Review PRs that need a code review Stale The label used by the Close Stale Issues action labels Oct 13, 2022
@sgiehl sgiehl merged commit f2cf949 into matomo-org:4.x-dev Oct 13, 2022
@justinvelluppillai justinvelluppillai changed the title Visits Overview: Remove redundant information for better a11y. Visits Overview accessibility improvement - remove redundant information Oct 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: Accessibility When something is not usable for a certain group (eg missing contrast) or devices (eg smartphones).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants