Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide redundant information from assistive technologies #19807

Closed
audrasjb opened this issue Oct 3, 2022 · 2 comments
Closed

Hide redundant information from assistive technologies #19807

audrasjb opened this issue Oct 3, 2022 · 2 comments
Labels
c: Accessibility When something is not usable for a certain group (eg missing contrast) or devices (eg smartphones). not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.

Comments

@audrasjb
Copy link
Contributor

audrasjb commented Oct 3, 2022

Expected Behavior

On several places of the admin, assistive technologies users will get redundant information due to duplicate info between text and title attributes, etc.

Current Behavior

For example, it's the case on the Visits overview dashboard widget.
I can open a new PR for each occurrence I find. Hopefully it will help removing those redundant info.
For example, on the Visits Overview widget we currently have:

<span class="metricEvolution" title="3 visits in 2022-10-02 compared to 8 visits in 2022-10-01. Evolution: -62,5%">
    <img style="padding-right:4px" src="plugins/MultiSites/images/arrow_down.png">
    <strong class="negative-evolution">-62,5&nbsp;%</strong>
</span>

Possible Solution

aria-hidden="true" can be used to hide redundant info from assistive technologies.
That's the case when the most complete information for non sighted users is provided by a title attribute: then we can remove other redundant info.
For example, on the Visits Overview widget, we could have:

<span class="metricEvolution" title="3 visits in 2022-10-02 compared to 8 visits in 2022-10-01. Evolution: -62,5%">
    <img style="padding-right:4px" src="plugins/MultiSites/images/arrow_down.png" alt="">
    <strong class="negative-evolution" aria-hidden="true">-62,5&nbsp;%</strong>
</span>

Your Environment

  • Matomo Version: last release.
  • PHP Version: 7.4
  • Server Operating System: Linux
  • Additionally installed plugins: None
@audrasjb audrasjb added the Potential Bug Something that might be a bug, but needs validation and confirmation it can be reproduced. label Oct 3, 2022
@sgiehl sgiehl added c: Accessibility When something is not usable for a certain group (eg missing contrast) or devices (eg smartphones). and removed Potential Bug Something that might be a bug, but needs validation and confirmation it can be reproduced. labels Oct 5, 2022
@heurteph-ei
Copy link

As #19808 and #19809 are merged, and version 4.12.1 now released, I think this can be closed, now...?

@sgiehl
Copy link
Member

sgiehl commented Oct 28, 2022

I'll close this one now. If there are further suggestions on how to improve accessibility, feel free to create a new issue.

@sgiehl sgiehl closed this as completed Oct 28, 2022
@elabuwa elabuwa added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Nov 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: Accessibility When something is not usable for a certain group (eg missing contrast) or devices (eg smartphones). not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Development

No branches or pull requests

4 participants