Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes several typos through the codebase #19805

Merged
merged 7 commits into from Oct 7, 2022
Merged

Fixes several typos through the codebase #19805

merged 7 commits into from Oct 7, 2022

Conversation

nexxai
Copy link
Contributor

@nexxai nexxai commented Oct 3, 2022

Description:

Cleaning up typos throughout the codebase

Review

@nexxai @justinvelluppillai
Update core/Plugin/Dimension/VisitDimension.php
f8ffeb5 
Co-authored-by: Justin Velluppillai <justinvelluppillai@gmail.com>
@justinvelluppillai justinvelluppillai added the Needs Review PRs that need a code review label Oct 3, 2022
peterhashair
peterhashair reviewed Oct 3, 2022
View reviewed changes
Copy link
Contributor

@peterhashair peterhashair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

really good typo fixes but seems like lots of test failed caused of some of those change, we can fix those later

@justinvelluppillai
Copy link
Contributor

Those failures look directly related, we should fix them before merging most likely

@nexxai
Copy link
Contributor Author

nexxai commented Oct 4, 2022

In the broken CI runs:

Happy to look into this more if someone can give me a little guidance.

@sgiehl sgiehl added this to the 4.12.1 milestone Oct 6, 2022
@sgiehl
Copy link
Member

sgiehl commented Oct 6, 2022

@nexxai would you mind merging in the latest changes from 4.x-dev? I think that should actually fix the tests

@sgiehl sgiehl added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Oct 6, 2022
@nexxai
Copy link
Contributor Author

nexxai commented Oct 6, 2022

@sgiehl Done

sgiehl
sgiehl approved these changes Oct 7, 2022
View reviewed changes
Copy link
Member

@sgiehl sgiehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now. One screenshot test needs an update, but I'll do that after merging the PR.
thanks @nexxai for your contribution.

@sgiehl sgiehl merged commit d3de8d6 into matomo-org:4.x-dev Oct 7, 2022
@justinvelluppillai justinvelluppillai changed the title Typofixes Fixes several typos through the codebase Oct 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinvelluppillai justinvelluppillai justinvelluppillai left review comments

@peterhashair peterhashair peterhashair left review comments

@sgiehl sgiehl sgiehl approved these changes

Assignees
No one assigned
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
4.12.1
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@nexxai @justinvelluppillai @sgiehl @peterhashair