Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved text and links in the Matomo Help Centre #19798

Merged
merged 6 commits into from Oct 6, 2022

Conversation

snake14
Copy link
Contributor

@snake14 snake14 commented Sep 30, 2022

Description:

We are updating some of the text and links in the Matomo Help Centre to try and make it a little more user friendly and informative.
Jira Issue: PG-1320

Review

@snake14 snake14 added the Needs Review PRs that need a code review label Sep 30, 2022
@snake14 snake14 marked this pull request as ready for review September 30, 2022 04:14
@@ -38,7 +39,7 @@
"TopLinkTooltip": "Tell us what you think, or request Professional Support.",
"ViewAnswersToFAQ": "View answers to %1$sFrequently Asked Questions%2$s",
"FAQs": "FAQs",
"ViewUserGuides": "Learn how to configure Matomo and how to effectively analyze your data with our %1$suser guides%2$s",
"ViewUserGuides": "FAQs, comprehensive guides, how-to’s and troubleshooting documents.",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can't replace a translation string with placeholders with one without. We need to create a new key for the new translation string without the placeholder, and remove the old one if no longer needed. This way weblate will handle the translations correctly for other languages.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. I just reverted a couple translations and created new ones instead.

Copy link
Contributor

@peterhashair peterhashair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great, but maybe just add some campaign param, to help us tracking the article.

plugins/Feedback/templates/index.twig Outdated Show resolved Hide resolved
plugins/Feedback/templates/index.twig Outdated Show resolved Hide resolved
plugins/Feedback/templates/index.twig Outdated Show resolved Hide resolved
@snake14
Copy link
Contributor Author

snake14 commented Oct 4, 2022

Thank you @peterhashair . I have added the recommended changes.

@sgiehl
Copy link
Member

sgiehl commented Oct 5, 2022

@snake14 If you remove the usage of a translation, you should check if they are in use anywhere else. If they are unused afterwards you can also remove them from en.json.

@snake14
Copy link
Contributor Author

snake14 commented Oct 5, 2022

@snake14 If you remove the usage of a translation, you should check if they are in use anywhere else. If they are unused afterwards you can also remove them from en.json.

Thank you @sgiehl . I went ahead and removed the translation key that isn't being used anymore.

@sgiehl sgiehl added this to the 4.12.1 milestone Oct 6, 2022
@sgiehl
Copy link
Member

sgiehl commented Oct 6, 2022

code looks fine so far. I've merged in the latest changes from 4.x-dev.
If tests are passing, this should be good to merge.

@sgiehl
Copy link
Member

sgiehl commented Oct 6, 2022

test failures are unrelated.

@sgiehl sgiehl merged commit bbb545a into 4.x-dev Oct 6, 2022
@sgiehl sgiehl deleted the pg-1320-update-matomo-help-centre branch October 6, 2022 13:11
@sgiehl sgiehl added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. and removed Needs Review PRs that need a code review labels Oct 6, 2022
@snake14
Copy link
Contributor Author

snake14 commented Oct 6, 2022

@sgiehl Thank you for your help 👍

@justinvelluppillai justinvelluppillai changed the title Updated the text and links in the Matomo Help Centre. Improved text and links in the Matomo Help Centre Oct 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants