@snake14 opened this Pull Request on September 30th 2022 Contributor

Description:

We are updating some of the text and links in the Matomo Help Centre to try and make it a little more user friendly and informative.
Jira Issue: PG-1320

Review

@snake14 commented on October 4th 2022 Contributor

Thank you @peterhashair . I have added the recommended changes.

@sgiehl commented on October 5th 2022 Member

@snake14 If you remove the usage of a translation, you should check if they are in use anywhere else. If they are unused afterwards you can also remove them from en.json.

@snake14 commented on October 5th 2022 Contributor

@snake14 If you remove the usage of a translation, you should check if they are in use anywhere else. If they are unused afterwards you can also remove them from en.json.

Thank you @sgiehl . I went ahead and removed the translation key that isn't being used anymore.

@sgiehl commented on October 6th 2022 Member

code looks fine so far. I've merged in the latest changes from 4.x-dev.
If tests are passing, this should be good to merge.

@sgiehl commented on October 6th 2022 Member

test failures are unrelated.

@snake14 commented on October 6th 2022 Contributor

@sgiehl Thank you for your help :+1:

This Pull Request was closed on October 6th 2022
Powered by GitHub Issue Mirror