Allow plugin names to be up to 60 characters instead of 40 #19795
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adding plugin name checks with 60 characters limit
extend change log for plugin name
sgiehl
requested changes
Oct 4, 2022
There was a problem hiding this comment.
@peterhashair Did you check the other code for required changes? There is at least
matomo/plugins/CoreConsole/Commands/GeneratePlugin.php
Lines 137 to 139 in 1155273
which needs to be removed. Not sure if there are other places where similar stuff is checked.
remove strlen check on plugin put onto regex
|
@sgiehl I couldn't find anywhere else that has a 40 char limit, anywhere I need to be aware? |
sgiehl
requested changes
Oct 6, 2022
Co-authored-by: Stefan Giehl <stefan@matomo.org>
peterhashair
added
Needs Review
added 2 commits
October 17, 2022 14:02
update function name
|
This PR maybe require other docs to update. |
sgiehl
approved these changes
Oct 28, 2022
elabuwa
changed the title
elabuwa
added
the
not-in-changelog
bx80
pushed a commit
that referenced
this pull request
Nov 25, 2022
* adding plugin name checks with 60 characters limit adding plugin name checks with 60 characters limit * extend change log for plugin name extend change log for plugin name * remove strlen check on plugin put onto regex remove strlen check on plugin put onto regex * Update CHANGELOG.md Co-authored-by: Stefan Giehl <stefan@matomo.org> * update function name update function name Co-authored-by: Stefan Giehl <stefan@matomo.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Fixes: #18727
adding plugin name checks with 60 characters limit
Review