Detect consent managers on the selected site and show a setup link #19789
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* hot fix give default period hot fix give default period * update to user default period update to user default period * add default date param in templates add default date param in templates
…19738) * Adding the abililty to exclude specific sites from the Vue site selector component. * Adding more time to make sure that the select is loaded before trying to search. * Changed things to filter the site on the server side. * Added a few new test cases. * Increasing amount of time for test. * Updated the omnifixture. * Fixing logic error in view. * Removed collation from omnifixture since it was causing issues. * Switching omnifixture back to 4.x-dev version. * Making just the bare essential changes to make local test fixtures build correctly. * Updating screenshot of API list. * revert OmniFixture-dump to 4.x-dev revert OmniFixture-dump to 4.x-dev Co-authored-by: Peter <peter@innocraft.com>
bx80
added
the
Enhancement
* Added config option to disable archiving for actions goals * Additionally disable entry page goals archiving if the config option is set * Use GeneralConfig::getConfigValue to allow support for site specific config settings * Updated UI test screenshot
| ; By default Matomo will archive data showing the contribution of each action to goal conversions, for sites tracking millions | ||
| ; of visits with a large number of goals this may negatively impact archiving performance. You can disable archiving of action | ||
| ; goal contribution here: | ||
| disable_archive_actions_goals = 0 |
There was a problem hiding this comment.
Looks like you've got a bit of code from your other PR in here?
There was a problem hiding this comment.
Or maybe this is branched off 4.x-dev not next_release branch?
There was a problem hiding this comment.
It was originally branched off 4.x-dev, I did rebase to next_release though, so not quite sure why those other commits are being included.
|
Closed in favor of 19794 |
bx80
added
duplicate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR adds a new 'challenge' to the 'Become a Matomo Expert' widget which is part of the Tour plugin. It will check for popular consent managers installed on the currently selected site and if detected will show a link to an FAQ showing how to integrate them with Matomo. Additionally it will check to see if the integration code is present on the website and if so automatically mark the challenge as complete.
A bit more detail:
When the
Challengeobject is constructed it will perform a simple cURL request to grab the current site main URL into a string and then check this against a known list of consent manager identifiers.There are three possible outcomes:
Challenge::isDisabled()method to disable itself and it will not be shown on the widget.The known consent managers are stored in a assoc array with detection strings and the URL for the guide, this can easily be extended in the future to cover more consent managers.
Currently supported: Osano, Cookiebot, CookieYes, Tarte au Citron, Klaro and Complianz GDPR for WordPress.
The linked guides are not public yet, but the included URLs will point to the correct location when they published.
One issue to consider is that this will cause a page load hit to the tracked website every time the widget is loaded. We could possibly soften this by adding a 'last checked' timestamp somewhere to ensure that we never check more frequently than say every 5 minutes. Another tweak could be to set the last checked timestamp a week(?) into the future if either no consent manager is detected or the consent manager is detected and is connected. Additionally we might want the cURL page load to use a user agent that avoids tracking or at least identifies as a robot of some sort.
Thoughts on this much appreciated!
Ref: DEV-3004
Review