Remove uppercase on segment autocomplete #19777
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…19738) * Adding the abililty to exclude specific sites from the Vue site selector component. * Adding more time to make sure that the select is loaded before trying to search. * Changed things to filter the site on the server side. * Added a few new test cases. * Increasing amount of time for test. * Updated the omnifixture. * Fixing logic error in view. * Removed collation from omnifixture since it was causing issues. * Switching omnifixture back to 4.x-dev version. * Making just the bare essential changes to make local test fixtures build correctly. * Updating screenshot of API list. * revert OmniFixture-dump to 4.x-dev revert OmniFixture-dump to 4.x-dev Co-authored-by: Peter <peter@innocraft.com>
bx80
added
c: Design / UI
|
@mindbreaker sorry to bother you, I am trying to merge this, but seems like there are some conflicts, do you mind fork a new PR based on |
|
This issue is in "needs review" but there has been no activity for 7 days. ping @matomo-org/core-reviewers |
github-actions
bot
added
the
Stale
peterhashair
approved these changes
Oct 12, 2022
There was a problem hiding this comment.
Looks good to me, we can add UI updates and UI tests later on. Ping @bx80
|
This one has been replaced with #19958 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the value is typed in a segment, it appears in capital letters. As a value, however, it is then taken over in such a way that only the first letter is written in capital letters.