Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Segment auto suggest capitalization #19773

Closed
mindbreaker opened this issue Sep 26, 2022 · 5 comments · Fixed by #19958
Closed

Segment auto suggest capitalization #19773

mindbreaker opened this issue Sep 26, 2022 · 5 comments · Fixed by #19958
Labels
c: Design / UI For issues that impact Matomo's user interface or the design overall. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Milestone

Comments

@mindbreaker
Copy link
Contributor

When the value is typed in a segment, it appears in capital letters. As a value, however, it is then taken over in such a way that only the first letter is written in capital letters.

Issue in forum: https://forum.matomo.org/t/segment-autosuggest-capitalization/47525

Expected Behavior

The value should be displayed in the auto-completion as it should actually be taken over in the field. For example:
If you want to select the country "Austria" it is displayed as "AUSTRIA" in the Autosuggest. But the value is "Austria".

@mindbreaker mindbreaker added the Potential Bug Something that might be a bug, but needs validation and confirmation it can be reproduced. label Sep 26, 2022
@MatomoForumNotifications

This issue has been mentioned on Matomo forums. There might be relevant details there:

https://forum.matomo.org/t/segment-autosuggest-capitalization/47525/2

@bx80
Copy link
Contributor

bx80 commented Sep 27, 2022

Hi @mindbreaker, thanks for reporting this. The auto-completion list has a text-transform: uppercase style applied which shows all list items as uppercase even though the underlying value is first letter capital only. This seems unnecessary and it would be better if the displayed list value was consistent when chosen.

I've assigned this issue for prioritization.

@bx80 bx80 added c: Design / UI For issues that impact Matomo's user interface or the design overall. and removed Potential Bug Something that might be a bug, but needs validation and confirmation it can be reproduced. labels Sep 27, 2022
@bx80 bx80 added this to the For Prioritization milestone Sep 27, 2022
@mindbreaker
Copy link
Contributor Author

OK. I created a pull request:
#19777

@bx80 bx80 modified the milestones: For Prioritization, 5.0.0 Sep 28, 2022
@bx80
Copy link
Contributor

bx80 commented Sep 28, 2022

Thanks for the pull request @mindbreaker, I've assigned it to the next release milestone 👍

@mindbreaker
Copy link
Contributor Author

Thx. @bx80 i see that the merge needs another approval.

@peterhashair peterhashair linked a pull request Nov 7, 2022 that will close this issue
@peterhashair peterhashair linked a pull request Nov 7, 2022 that will close this issue
11 tasks
@sgiehl sgiehl closed this as completed Nov 9, 2022
@elabuwa elabuwa added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Nov 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: Design / UI For issues that impact Matomo's user interface or the design overall. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants