New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to Matomo 4.12 breaks Matomo when DeviceDetectorCache plugin is installed #19768
Comments
We would certainly need to release a new version of that plugin and require I'm not sure about also releasing another update with We would need to release these updates ASAP to prevent people running into problems when they upgrade. I believe Matomo should be updating plugins together with core and it should prevent this issue in most cases although I'm not 100% sure (would need to be double checked). It'll remain a problem for people upgrading manually where they'll need to make sure to also update the plugin. |
Generate a PR that updates plugin.json and CHANGELOG.md, @AltamashShaikh will release 4.3.0 should fix this one. will test it after release. |
@peterhashair did you do any testing with Matomo and that plugin? This issue was most likely not solved by simply increasing the minimum required matomo version in the plugin. The latest DeviceDetectorCache plugin is compatible with previous Matomo versions. But Matomo became incompatible with older versions of the plugin. So updating Matomo without updating the plugin can cause this problem. That is actually a case we currently are not able to handle cleanly. As we don't have a possibility to define that a plugin update is required. As @tsteur mentioned, we could have released a version of the plugin, without the changes, and mark it as compatible til Matomo 4.12.0. But even that would not solve the problem for all Matomo users, as Matomo might not yet use that plugin version when an update is triggered. But it would at least solve the problem for a couple of cases.... Btw. The error actually only occurs with PHP 8. Seems PHP 7 was not yet that strict with method compatibility |
@sgiehl yes, I thought to release a lower version, with 4.11 comparable |
@tsteur Does the marketplace accept releases that are lower then the latest version, but within the same major version? |
I think it would let you release that. It's also supported to release updates for eg your 3.X-dev etc. The marketplace should then remove any version it's not compatible with AFAIK. What would be important
|
I have now released @tsteur is it normal that after releasing |
@sgiehl I think that be expected currently for the user interface on plugins.matomo.org. The API would then suggest the correct version depending on their specific Matomo install (the UI on plugins.matomo.org doesn't pretend to be a specific Matomo version so it shows all). I do wonder though if you were on Matomo 4.3.1 if it would recognise that |
Upgraded to Matomo 4.12-rc1 and got this result:
Looks like there was a breaking API change in that release causing this issue. The only way to fix this was to manually revert to the previous Matomo version.
Seems there was this change matomo-org/plugin-DeviceDetectorCache@e7ddda8 but if we released that, it would actually break Matomo for heaps of users who are on an older version as required Matomo version wasn't adjusted.
The text was updated successfully, but these errors were encountered: