Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

display notice when viewing a segment that requires profilable data but the period is not profilable #19764

Draft
wants to merge 17 commits into
base: 4.x-dev
Choose a base branch
from
Draft

display notice when viewing a segment that requires profilable data but the period is not profilable #19764

wants to merge 17 commits into from

Conversation

diosmosis
Copy link
Member

@diosmosis diosmosis commented Sep 25, 2022 •
edited

Description:

This PR is based off of #19763.

Refs #16363

Changes:

  • Allow Dimensions to mark themselves as requiring profilable data.
  • Use above information to detect if a segment requires profilable data to be accurate.
  • If the current period is not majority profilable and the current segment requires profilable data, display a sterner warning about the data in Visualization.php.

Review

@diosmosis
add nb_profilable metric to count number of visits that were profilable
527f0a2
@diosmosis
update expected test files
fdae0c2
@diosmosis
add nb_profilable as metric to VisitsSummary.Get report
c1d575e
@diosmosis
add metric translation and documentation
39c1bc3
@diosmosis
update expected test files (adding profilable metric)
7ceb101
@diosmosis
update submodules
bf89222
@diosmosis
update expected test files
668aba4
@diosmosis
fix test for added metric
a4f5ea2
@diosmosis
fixing tests
f6c34dd
@diosmosis
update expected screenshots
7835b57
@diosmosis
update expected test files
051817c
@diosmosis
update expected test files
97b4303
@diosmosis
update expected tests
9fae99d
@diosmosis
Merge branch '4.x-dev' into 16363-profilable-metric
6a957e3
@diosmosis
remove unique visitor metrics from API response if period is not majo…
48170ab 
…rity profilable
@diosmosis
remove metrics from tables and sparklines visualization if current pe…
56e903a 
…riod is not profilable + display warning about this + add UI test for UI when period is not profilable
@diosmosis
allow dimensions to mark themselves as requiring profilable data, det…
febaf51 
…ect when a segment requires profilable data, and if a segment requires profilable data but the current period is not profilable, display a custom message
@diosmosis diosmosis marked this pull request as draft September 25, 2022 07:47
@github-actions
Copy link
Contributor

If you don't want this PR to be closed automatically in 28 days then you need to assign the label 'Do not close'.

@github-actions github-actions bot added the Stale The label used by the Close Stale Issues action label Oct 10, 2022
@github-actions
Copy link
Contributor

This PR was last updated more than one month ago, maybe it's time to close it. Please check if there is anything we still can do or close this PR. ping @matomo-org/core-reviewers

@github-actions github-actions bot added the Stale for long The label used by the Close Stale Issues action label Nov 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Stale for long The label used by the Close Stale Issues action Stale The label used by the Close Stale Issues action
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@diosmosis