Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do not display metrics that require profilable data if the current periods is not profilable #19763

Draft
wants to merge 16 commits into
base: 4.x-dev
Choose a base branch
from

Conversation

diosmosis
Copy link
Member

Description:

This PR is based off of #19745.

Refs #16363

Changes:

  • in API output, if the current period is not majority profilable (> 99% profilable visits), remove unique visitors & other metrics from the output
  • in ViewDataTable\Config, remove unique visitors from the default metrics to display if the current period is not majority profilable
  • in the Sparklines visualization, if the current period is not majority profilable, do not add metrics to the list of sparklines to display if they depend on profilable data
  • in Visualization.php, if the current period is not majority profilable, display an info notification mentioning this and linking to a (as of yet, unwritten) FAQ or documentation page on the website

Notes:

  • in this PR the segment is not accounted for when determining if the current period is profilable. So even if there is a segment in the request (eg, browserCode==ff), we check the percentage of profilable visits in the "All Visits" segment regardless. I think this was to make the UI more consistent.

Review

@github-actions
Copy link
Contributor

If you don't want this PR to be closed automatically in 28 days then you need to assign the label 'Do not close'.

@github-actions github-actions bot added the Stale The label used by the Close Stale Issues action label Oct 10, 2022
@github-actions
Copy link
Contributor

This PR was last updated more than one month ago, maybe it's time to close it. Please check if there is anything we still can do or close this PR. ping @matomo-org/core-reviewers

@github-actions github-actions bot added the Stale for long The label used by the Close Stale Issues action label Nov 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Stale for long The label used by the Close Stale Issues action Stale The label used by the Close Stale Issues action
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant