@diosmosis opened this Pull Request on September 25th 2022 Member

Description:

This PR is based off of #19745.

Refs #16363

Changes:

  • in API output, if the current period is not majority profilable (> 99% profilable visits), remove unique visitors & other metrics from the output
  • in ViewDataTable\Config, remove unique visitors from the default metrics to display if the current period is not majority profilable
  • in the Sparklines visualization, if the current period is not majority profilable, do not add metrics to the list of sparklines to display if they depend on profilable data
  • in Visualization.php, if the current period is not majority profilable, display an info notification mentioning this and linking to a (as of yet, unwritten) FAQ or documentation page on the website

Notes:

  • in this PR the segment is not accounted for when determining if the current period is profilable. So even if there is a segment in the request (eg, browserCode==ff), we check the percentage of profilable visits in the "All Visits" segment regardless. I think this was to make the UI more consistent.

Review

@github-actions[bot] commented on October 10th 2022 Contributor

If you don't want this PR to be closed automatically in 28 days then you need to assign the label 'Do not close'.

@github-actions[bot] commented on November 22nd 2022 Contributor

This PR was last updated more than one month ago, maybe it's time to close it. Please check if there is anything we still can do or close this PR. ping @matomo-org/core-reviewers

Powered by GitHub Issue Mirror