experiment with only processing profilable visits for a report that needs it #19762
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…by days since last report as experiment. + add multiFilter() utility function in DataTable since I see the pattern often
diosmosis
changed the title
|
If you don't want this PR to be closed automatically in 28 days then you need to assign the label 'Do not close'. |
github-actions
bot
added
the
Stale
mattab
added
the
Do not close
github-actions
bot
removed
the
Stale
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR is based off of #19745.
Refs #16363
This PR is an alternate UX idea for one part of #16363. The issue asks to hide certain reports that depend on profilable data for accuracy. This PR takes one of those reports and modifies it to only aggregate profilable data and also report the number of visits that are not profilable:
Periods w/ 'unprofilable' are displayed with the number of unprofilable visits:
The row as an info icon that would link to documentation explaining the concept and why they're seeing that.
Periods w/o 'unprofilable' visits have an empty value for that row:
@mattab @jane-twizel @tsteur @Javi-Ormaechea can I get your opinion on whether this is a viable solution (in terms of UX and other areas) to the part of #16363 dealing w/ these kinds of reports? Do you think its a better or worse solution than simply hiding the report entirely if > 99% of visits are not profilable, and allowing the data to display in all other cases?
Review