Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TwoFactorAuth: Deprecated - str_replace() on PHP 8.1.9 #19753

Closed
JE4GLE opened this issue Sep 21, 2022 · 2 comments · Fixed by #19756
Closed

TwoFactorAuth: Deprecated - str_replace() on PHP 8.1.9 #19753

JE4GLE opened this issue Sep 21, 2022 · 2 comments · Fixed by #19756
Labels
Help wanted Beginner friendly issues or issues where we'd highly appreciate community's help and involvement. Regression Indicates a feature used to work in a certain way but it no longer does even though it should.
Milestone
4.12.0

Comments

@JE4GLE
Copy link
Contributor

JE4GLE commented Sep 21, 2022 •
edited

Hi!

WARNING: /plugins/TwoFactorAuth/TwoFactorAuth.php(255): Deprecated - str_replace(): Passing null to parameter #3 ($subject) of type array|string is deprecated - Matomo 4.11.0 - Please report this message in the Matomo forums: https://forum.matomo.org 1 (please do a search first as it might have been reported already) (Module: Proxy, Action: getNonCoreJs, In CLI mode: false)

I don‘t think, I have to add more. The error message is pretty self-explanatory 😅
@JE4GLE JE4GLE added the Potential Bug Something that might be a bug, but needs validation and confirmation it can be reproduced. label Sep 21, 2022
@MatomoForumNotifications
Copy link

This issue has been mentioned on Matomo forums. There might be relevant details there:

https://forum.matomo.org/t/twofactorauth-deprecated-str-replace-on-php-8-1-9/47451/3

@peterhashair
Copy link
Contributor

@JE4GLE Thank you for reporting this, looks like we could use a null check there.

@peterhashair peterhashair added this to the For Prioritization milestone Sep 22, 2022
@peterhashair peterhashair added Help wanted Beginner friendly issues or issues where we'd highly appreciate community's help and involvement. and removed Potential Bug Something that might be a bug, but needs validation and confirmation it can be reproduced. labels Sep 22, 2022
@justinvelluppillai justinvelluppillai mentioned this issue Sep 22, 2022
Merged
11 tasks
@justinvelluppillai justinvelluppillai added the Regression Indicates a feature used to work in a certain way but it no longer does even though it should. label Sep 22, 2022
@peterhashair peterhashair linked a pull request Sep 27, 2022 that will close this issue
PHP8.1 fix: we don't need to check for leaked tokens in an empty string #19756
Merged
11 tasks
@heurteph-ei heurteph-ei mentioned this issue Jan 26, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Help wanted Beginner friendly issues or issues where we'd highly appreciate community's help and involvement. Regression Indicates a feature used to work in a certain way but it no longer does even though it should.
Projects
None yet
Milestone
4.12.0
Development

Successfully merging a pull request may close this issue.

PHP8.1 fix: we don't need to check for leaked tokens in an empty string matomo-org/matomo
4 participants
@justinvelluppillai @peterhashair @JE4GLE @MatomoForumNotifications